Changeset 18544 in vbox for trunk/src/VBox/Runtime/common

Timestamp:

Mar 30, 2009 1:18:50 PM (16 years ago)

Author:

vboxsync

Message:

RTStrToUpper/Lower: Document assumtions & todos properly, added missing spaces.

File:

• trunk/src/VBox/Runtime/common/string/utf-8.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/string/utf-8.cpp

@@ -1370 +1370 @@
 }
 
+
 RTDECL(char *) RTStrToLower(char *psz)
 {
-    char *pszTmp = psz;
-    while(*pszTmp)
-    {
-        /* Get the codepoints */
-        RTUNICP cp = RTStrGetCp(pszTmp);
-        /* To lower */
+    /*
+     * Loop the code points in the string, converting them one by one.
+     * ASSUMES that the code points for upper and lower case are encoded
+     *         with the exact same length.
+     */
+    /** @todo Handled bad encodings correctly+quietly, remove assumption,
+     *        optimize. */
+    char *pszCur = psz;
+    while (*pszCur)
+    {
+        RTUNICP cp = RTStrGetCp(pszCur);
         cp = RTUniCpToLower(cp);
-        /* Put the converted codepoint back */
-        pszTmp = RTStrPutCp(pszTmp, cp);
+        pszCur = RTStrPutCp(pszCur, cp);
     }
     return psz;
 }
 
+
 RTDECL(char *) RTStrToUpper(char *psz)
 {
-    char *pszTmp = psz;
-    while(*pszTmp)
-    {
-        /* Get the codepoints */
-        RTUNICP cp = RTStrGetCp(pszTmp);
-        /* To lower */
+    /*
+     * Loop the code points in the string, converting them one by one.
+     * ASSUMES that the code points for upper and lower case are encoded
+     *         with the exact same length.
+     */
+    /** @todo Handled bad encodings correctly+quietly, remove assumption,
+     *        optimize. */
+    char *pszCur = psz;
+    while(*pszCur)
+    {
+        RTUNICP cp = RTStrGetCp(pszCur);
         cp = RTUniCpToUpper(cp);
-        /* Put the converted codepoint back */
-        pszTmp = RTStrPutCp(pszTmp, cp);
+        pszCur = RTStrPutCp(pszCur, cp);
     }
     return psz;