Changeset 1858 in vbox for trunk

Timestamp:

Apr 2, 2007 12:29:41 PM (18 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

20073

Message:

pfnDriverAttach has to pass the real return value of pfnConstruct, not VINF_SUCCESS. I checked that every device is able to handle this correctly.

File:

• trunk/src/VBox/VMM/PDMDevice.cpp (modified) (1 diff)

trunk/src/VBox/VMM/PDMDevice.cpp

@@ -1951 +1951 @@
                                  pDrv->pDrvReg->szDriverName, pNew->iInstance, iLun, pDevIns->pDevReg->szDeviceName, pDevIns->iInstance));
                             LogFlow(("pdmR3DevHlp_DriverAttach: caller '%s'/%d: returns %Vrc\n", pDevIns->pDevReg->szDeviceName, pDevIns->iInstance, VINF_SUCCESS));
-                            return VINF_SUCCESS;
+                            /*
+                             * Might return != VINF_SUCCESS (e.g. VINF_NAT_DNS) */
+                            return rc;
                         }