Changeset 18645 in vbox for trunk/src/VBox/Devices

Timestamp:

Apr 2, 2009 3:38:31 PM (16 years ago)

Author:

vboxsync

Message:

VMSetRuntimeError[V] refactoring: fFatal -> fFlags, may return informational status codes.

Location:

trunk/src/VBox/Devices

Files:

• Audio/DevIchAc97.cpp (modified) (2 diffs)
• Audio/DevSB16.cpp (modified) (1 diff)
• Network/DevE1000.cpp (modified) (1 diff)
• Network/DevPCNet.cpp (modified) (1 diff)
• Network/DrvNAT.cpp (modified) (3 diffs)
• Serial/DrvHostSerial.cpp (modified) (4 diffs)
• Storage/DevATA.cpp (modified) (4 diffs)
• Storage/DrvHostBase.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -1680 +1680 @@
         ac97Reset (pDevIns);
 
-        PDMDevHlpVMSetRuntimeError (pDevIns, false, "HostAudioNotResponding",
+        PDMDevHlpVMSetRuntimeError (pDevIns, 0 /*fFlags*/, "HostAudioNotResponding",
             N_ ("No audio devices could be opened. Selecting the NULL audio backend "
                 "with the consequence that no sound is audible"));
@@ -1696 +1696 @@
             len += RTStrPrintf (szMissingVoices + len, sizeof(szMissingVoices) - len, len ? ", PCM_mic" : "PCM_mic");
 
-        PDMDevHlpVMSetRuntimeError (pDevIns, false, "HostAudioNotResponding",
+        PDMDevHlpVMSetRuntimeError (pDevIns, 0 /*fFlags*/, "HostAudioNotResponding",
             N_ ("Some audio devices (%s) could not be opened. Guest applications generating audio "
                 "output or depending on audio input may hang. Make sure your host audio device "

trunk/src/VBox/Devices/Audio/DevSB16.cpp

@@ -1836 +1836 @@
         s->voice = NULL;
         AUD_init_null();
-        PDMDevHlpVMSetRuntimeError(pDevIns, false, "HostAudioNotResponding",
+        PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "HostAudioNotResponding",
             N_("No audio devices could be opened. Selecting the NULL audio backend "
                "with the consequence that no sound is audible"));

trunk/src/VBox/Devices/Network/DevE1000.cpp

@@ -4853 +4853 @@
         if (rc == VINF_NAT_DNS)
         {
-            VMSetRuntimeError(PDMDevHlpGetVM(pDevIns), false, "NoDNSforNAT",
-                              N_("A Domain Name Server (DNS) for NAT networking could not be determined. Ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
+            PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "NoDNSforNAT",
+                                       N_("A Domain Name Server (DNS) for NAT networking could not be determined. Ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
         }
         pState->pDrv = (PPDMINETWORKCONNECTOR)

trunk/src/VBox/Devices/Network/DevPCNet.cpp

@@ -4991 +4991 @@
         {
 #ifdef RT_OS_LINUX
-            VMSetRuntimeError(PDMDevHlpGetVM(pDevIns), false, "NoDNSforNAT",
-                              N_("A Domain Name Server (DNS) for NAT networking could not be determined. Please check your /etc/resolv.conf for <tt>nameserver</tt> entries. Either add one manually (<i>man resolv.conf</i>) or ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
+            PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "NoDNSforNAT",
+                                       N_("A Domain Name Server (DNS) for NAT networking could not be determined. Please check your /etc/resolv.conf for <tt>nameserver</tt> entries. Either add one manually (<i>man resolv.conf</i>) or ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
 #else
-            VMSetRuntimeError(PDMDevHlpGetVM(pDevIns), false, "NoDNSforNAT",
-                              N_("A Domain Name Server (DNS) for NAT networking could not be determined. Ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
+            PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "NoDNSforNAT",
+                                       N_("A Domain Name Server (DNS) for NAT networking could not be determined. Ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
 #endif
         }

trunk/src/VBox/Devices/Network/DrvNAT.cpp

@@ -387 +387 @@
 
         int cChangedFDs = poll(polls, nFDs + 1, ms ? ms : -1);
+#ifndef RT_OS_LINUX /* 2.6.23 + gdb -> hitting all the time. probably a bug in poll/ptrace/whatever. */
         AssertRelease(cChangedFDs >= 0);
+#endif
         if (cChangedFDs >= 0)
         {
@@ -397 +399 @@
                 size_t cbRead;
                 int counter = 0;
-                /* 
-                 * drvNATSend decoupled so we don't know how many times 
+                /*
+                 * drvNATSend decoupled so we don't know how many times
                  * device's thread sends before we've entered multiplex,
                  * so to avoid false alarm drain pipe here to the very end
                  *
-                 * @todo: Probably we should counter drvNATSend to count how 
-                 * deep pipe has been filed before drain. 
+                 * @todo: Probably we should counter drvNATSend to count how
+                 * deep pipe has been filed before drain.
                  *
                  * XXX:Make it reading exactly we need to drain the pipe.
@@ -564 +566 @@
         cDroppedPackets++;
     }
-    else 
+    else
     {
         LogRel(("NAT: %d messages suppressed about dropping package (couldn't allocate queue item)\n", cDroppedPackets));

trunk/src/VBox/Devices/Serial/DrvHostSerial.cpp

@@ -974 +974 @@
         {
 ioctl_error:
-            PDMDrvHlpVMSetRuntimeError(pDrvIns, false, "DrvHostSerialFail",
+            PDMDrvHlpVMSetRuntimeError(pDrvIns, 0 /*fFlags*/, "DrvHostSerialFail",
                                        N_("Ioctl failed for serial host device '%s' (%Rrc). The device will not work properly"),
                                        pThis->pszDevicePath, RTErrConvertFromErrno(errno));
@@ -990 +990 @@
         if (rc < 0)
         {
-            PDMDrvHlpVMSetRuntimeError(pDrvIns, false, "DrvHostSerialFail",
+            PDMDrvHlpVMSetRuntimeError(pDrvIns, 0 /*fFlags*/, "DrvHostSerialFail",
                                        N_("Ioctl failed for serial host device '%s' (%Rrc). The device will not work properly"),
                                        pThis->pszDevicePath, RTErrConvertFromErrno(errno));
@@ -1092 +1092 @@
 
 ioctl_error:
-    PDMDrvHlpVMSetRuntimeError(pDrvIns, false, "DrvHostSerialFail",
+    PDMDrvHlpVMSetRuntimeError(pDrvIns, 0 /*fFlags*/, "DrvHostSerialFail",
                                 N_("Ioctl failed for serial host device '%s' (%Rrc). The device will not work properly"),
                                 pThis->pszDevicePath, RTErrConvertFromErrno(errno));
@@ -1112 +1112 @@
     rc = RTThreadPoke(pThread->Thread);
     if (RT_FAILURE(rc))
-        PDMDrvHlpVMSetRuntimeError(pDrvIns, false, "DrvHostSerialFail",
+        PDMDrvHlpVMSetRuntimeError(pDrvIns, 0 /*fFlags*/, "DrvHostSerialFail",
                                     N_("Suspending serial monitor thread failed for serial device '%s' (%Rrc). The shutdown may take longer than expected"),
                                     pThis->pszDevicePath, RTErrConvertFromErrno(rc));

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -1370 +1370 @@
     int rc;
     LogRel(("PIIX3 ATA: Host disk full\n"));
-    rc = VMSetRuntimeError(PDMDevHlpGetVM(pDevIns),
-                           false, "DevATA_DISKFULL",
-                           N_("Host system reported disk full. VM execution is suspended. You can resume after freeing some space"));
+    rc = PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "DevATA_DISKFULL",
+                                    N_("Host system reported disk full. VM execution is suspended. You can resume after freeing some space"));
     AssertRC(rc);
 }
@@ -1380 +1379 @@
     int rc;
     LogRel(("PIIX3 ATA: File too big\n"));
-    rc = VMSetRuntimeError(PDMDevHlpGetVM(pDevIns),
-                           false, "DevATA_FILETOOBIG",
-                           N_("Host system reported that the file size limit of the host file system has been exceeded. VM execution is suspended. You need to move your virtual hard disk to a filesystem which allows bigger files"));
+    rc = PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "DevATA_FILETOOBIG",
+                                    N_("Host system reported that the file size limit of the host file system has been exceeded. VM execution is suspended. You need to move your virtual hard disk to a filesystem which allows bigger files"));
     AssertRC(rc);
 }
@@ -1390 +1388 @@
     int rc;
     LogRel(("PIIX3 ATA: iSCSI target unavailable\n"));
-    rc = VMSetRuntimeError(PDMDevHlpGetVM(pDevIns),
-                           false, "DevATA_ISCSIDOWN",
-                           N_("The iSCSI target has stopped responding. VM execution is suspended. You can resume when it is available again"));
+    rc = PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "DevATA_ISCSIDOWN",
+                                    N_("The iSCSI target has stopped responding. VM execution is suspended. You can resume when it is available again"));
     AssertRC(rc);
 }
@@ -5239 +5236 @@
         if (!ataWaitForAsyncIOIsIdle(&pThis->aCts[i], 30000))
         {
-            VMSetRuntimeError(PDMDevHlpGetVM(pDevIns),
-                              false, "DevATA_ASYNCBUSY",
-                              N_("The IDE async I/O thread remained busy after a reset, usually a host filesystem performance problem\n"));
+            PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "DevATA_ASYNCBUSY",
+                                       N_("The IDE async I/O thread remained busy after a reset, usually a host filesystem performance problem\n"));
             AssertMsgFailed(("Async I/O thread busy after reset\n"));
         }

trunk/src/VBox/Devices/Storage/DrvHostBase.cpp

@@ -1973 +1973 @@
                 if (pThis->fAttachFailError)
                     return rc;
-                int erc = PDMDrvHlpVMSetRuntimeError(pDrvIns,
-                                                     false, "DrvHost_MOUNTFAIL",
+                int erc = PDMDrvHlpVMSetRuntimeError(pDrvIns, 0 /*fFlags*/,
+                                                     "DrvHost_MOUNTFAIL",
                                                      N_("Cannot attach to host device '%s'"), pszDevice);
                 AssertRC(erc);