Changeset 18645 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Apr 2, 2009 3:38:31 PM (16 years ago)

Author:

vboxsync

Message:

VMSetRuntimeError[V] refactoring: fFatal -> fFlags, may return informational status codes.

Location:

trunk/src/VBox/Devices/Network

Files:

• DevE1000.cpp (modified) (1 diff)
• DevPCNet.cpp (modified) (1 diff)
• DrvNAT.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Network/DevE1000.cpp

@@ -4853 +4853 @@
         if (rc == VINF_NAT_DNS)
         {
-            VMSetRuntimeError(PDMDevHlpGetVM(pDevIns), false, "NoDNSforNAT",
-                              N_("A Domain Name Server (DNS) for NAT networking could not be determined. Ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
+            PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "NoDNSforNAT",
+                                       N_("A Domain Name Server (DNS) for NAT networking could not be determined. Ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
         }
         pState->pDrv = (PPDMINETWORKCONNECTOR)

trunk/src/VBox/Devices/Network/DevPCNet.cpp

@@ -4991 +4991 @@
         {
 #ifdef RT_OS_LINUX
-            VMSetRuntimeError(PDMDevHlpGetVM(pDevIns), false, "NoDNSforNAT",
-                              N_("A Domain Name Server (DNS) for NAT networking could not be determined. Please check your /etc/resolv.conf for <tt>nameserver</tt> entries. Either add one manually (<i>man resolv.conf</i>) or ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
+            PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "NoDNSforNAT",
+                                       N_("A Domain Name Server (DNS) for NAT networking could not be determined. Please check your /etc/resolv.conf for <tt>nameserver</tt> entries. Either add one manually (<i>man resolv.conf</i>) or ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
 #else
-            VMSetRuntimeError(PDMDevHlpGetVM(pDevIns), false, "NoDNSforNAT",
-                              N_("A Domain Name Server (DNS) for NAT networking could not be determined. Ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
+            PDMDevHlpVMSetRuntimeError(pDevIns, 0 /*fFlags*/, "NoDNSforNAT",
+                                       N_("A Domain Name Server (DNS) for NAT networking could not be determined. Ensure that your host is correctly connected to an ISP. If you ignore this warning the guest will not be able to perform nameserver lookups and it will probably observe delays if trying so"));
 #endif
         }

trunk/src/VBox/Devices/Network/DrvNAT.cpp

@@ -387 +387 @@
 
         int cChangedFDs = poll(polls, nFDs + 1, ms ? ms : -1);
+#ifndef RT_OS_LINUX /* 2.6.23 + gdb -> hitting all the time. probably a bug in poll/ptrace/whatever. */
         AssertRelease(cChangedFDs >= 0);
+#endif
         if (cChangedFDs >= 0)
         {
@@ -397 +399 @@
                 size_t cbRead;
                 int counter = 0;
-                /* 
-                 * drvNATSend decoupled so we don't know how many times 
+                /*
+                 * drvNATSend decoupled so we don't know how many times
                  * device's thread sends before we've entered multiplex,
                  * so to avoid false alarm drain pipe here to the very end
                  *
-                 * @todo: Probably we should counter drvNATSend to count how 
-                 * deep pipe has been filed before drain. 
+                 * @todo: Probably we should counter drvNATSend to count how
+                 * deep pipe has been filed before drain.
                  *
                  * XXX:Make it reading exactly we need to drain the pipe.
@@ -564 +566 @@
         cDroppedPackets++;
     }
-    else 
+    else
     {
         LogRel(("NAT: %d messages suppressed about dropping package (couldn't allocate queue item)\n", cDroppedPackets));