Changeset 18778 in vbox for trunk/src/VBox

Timestamp:

Apr 6, 2009 3:33:28 PM (16 years ago)

Author:

vboxsync

Message:

Storage/DrvVD: don't pass VMSETRTERR_FLAGS_FATAL to pfnVMSetRuntimeErrorV() as it would cause a deadlock with EMT

File:

• trunk/src/VBox/Devices/Storage/DrvVD.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/DrvVD.cpp

@@ -160 +160 @@
     PVBOXDISK pThis = PDMINS_2_DATA(pDrvIns, PVBOXDISK);
     if (pThis->fErrorUseRuntime)
-        pDrvIns->pDrvHlp->pfnVMSetRuntimeErrorV(pDrvIns, VMSETRTERR_FLAGS_FATAL, "DrvVD", pszFormat, va);
+        /* We must not pass VMSETRTERR_FLAGS_FATAL as it could lead to a
+         * deadlock: We are probably executed in a thread context != EMT
+         * and the EM thread would wait until every thread is suspended
+         * but we would wait for the EM thread ... */
+        pDrvIns->pDrvHlp->pfnVMSetRuntimeErrorV(pDrvIns, /* fFlags=*/ 0, "DrvVD", pszFormat, va);
     else
         pDrvIns->pDrvHlp->pfnVMSetErrorV(pDrvIns, rc, RT_SRC_POS_ARGS, pszFormat, va);