Changeset 1908 in vbox for trunk/src/VBox

Timestamp:

Apr 4, 2007 7:49:50 AM (18 years ago)

Author:

vboxsync

Message:

Backed out part of 20091 to check if that's the cause of the major performance regression seen on testboxlin.

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllBth.h (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -903 +903 @@
             if (pShwPage->GCPhys == GCPhys)
             {
+#if 0 /* likely cause of a major performance regression; must be SyncPageWorkerTrackDeref then */
                 const unsigned iPTEDst = (GCPtrPage >> SHW_PT_SHIFT) & SHW_PT_MASK;
                 PSHWPT pPT = (PSHWPT)PGMPOOL_PAGE_2_PTR(pVM, pShwPage);
@@ -913 +914 @@
                     pPT->a[iPTEDst].u = 0;
                 }
+#else /* Syncing it here isn't 100% safe and it's probably not worth spending time syncing it. */ 
+                rc = PGM_BTH_NAME(SyncPage)(pVM, PdeSrc, GCPtrPage, 1, 0); 
+                if (VBOX_SUCCESS(rc)) 
+                    rc = VINF_SUCCESS; 
+#endif       
                 STAM_COUNTER_INC(&pVM->pgm.s.CTXMID(Stat,InvalidatePage4KBPages));
                 PGM_INVL_PG(GCPtrPage);