Changeset 19147 in vbox for trunk/src/VBox

Timestamp:

Apr 23, 2009 3:09:02 PM (16 years ago)

Author:

vboxsync

Message:

#3854: Error checking for skb_gso_segment().

Location:

trunk/src/VBox

Files:

• HostDrivers/VBoxNetFlt/linux/VBoxNetFlt-linux.c (modified) (1 diff)
• Runtime/VBox/log-vbox.cpp (modified) (1 diff)

trunk/src/VBox/HostDrivers/VBoxNetFlt/linux/VBoxNetFlt-linux.c

@@ -636 +636 @@
 #endif
 
-        for (pSegment = VBOX_SKB_GSO_SEGMENT(pBuf); pSegment; pSegment = pNext)
+        pSegment = VBOX_SKB_GSO_SEGMENT(pBuf);
+        if (IS_ERR(pSegment))
+        {
+            dev_kfree_skb(pBuf);
+            LogRel(("VBoxNetFlt: Failed to segment a packet (%d).\n", PRT_ERR(pBuf)));
+            return;
+        }
+        for (; pSegment; pSegment = pNext)
         {
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 18)

trunk/src/VBox/Runtime/VBox/log-vbox.cpp

@@ -419 +419 @@
 # endif
 # if defined(DEBUG_aleksey)  /* Guest ring-0 as well */
-        RTLogGroupSettings(pLogger, "+net_adp_drv.e.l.f+net_flt_drv.e.l.f+srv_intnet.e.l.f");
+        RTLogGroupSettings(pLogger, "+net_adp_drv.e.l.f+net_flt_drv.e.l.l2.l3.l4.f");
         RTLogFlags(pLogger, "enabled unbuffered");
         pLogger->fDestFlags |= RTLOGDEST_DEBUGGER | RTLOGDEST_STDOUT;