Changeset 19180 in vbox for trunk/src/VBox/VMM

Timestamp:

Apr 24, 2009 6:34:55 PM (16 years ago)

Author:

vboxsync

Message:

PGMAllPhys.cpp: PGMPhysGCPhys2HCPhys should take the pgm lock before accessing the ram pages. (No critical usage, mostly the debugger & dbgf.)

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllPhys.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/PGMAllPhys.cpp

@@ -179 +179 @@
 VMMDECL(int) PGMPhysGCPhys2HCPhys(PVM pVM, RTGCPHYS GCPhys, PRTHCPHYS pHCPhys)
 {
+    pgmLock(pVM);
     PPGMPAGE pPage;
     int rc = pgmPhysGetPageEx(&pVM->pgm.s, GCPhys, &pPage);
-    if (RT_FAILURE(rc))
-        return rc;
-
-    *pHCPhys = PGM_PAGE_GET_HCPHYS(pPage) | (GCPhys & PAGE_OFFSET_MASK);
-    return VINF_SUCCESS;
+    if (RT_SUCCESS(rc))
+        *pHCPhys = PGM_PAGE_GET_HCPHYS(pPage) | (GCPhys & PAGE_OFFSET_MASK);
+    pgmUnlock(pVM);
+    return rc;
 }