Changeset 19391 in vbox for trunk/src/VBox/Runtime/r0drv/solaris/vbi

Timestamp:

May 5, 2009 5:26:18 PM (16 years ago)

Author:

vboxsync

Message:

IPRT: Explained RTMpOthers preemption req to the caller in mp.h, but play safe. Comment in RTMpOnSpecific isn't relevant.

File:

• trunk/src/VBox/Runtime/r0drv/solaris/vbi/mp-r0drv-solaris.c (modified) (2 diffs)

trunk/src/VBox/Runtime/r0drv/solaris/vbi/mp-r0drv-solaris.c

@@ -204 +204 @@
     RTMPARGS Args;
 
+    /* The caller is supposed to have disabled preemption, but take no chances. */
+    vbi_preempt_disable();
+
     Args.pfnWorker = pfnWorker;
     Args.pvUser1 = pvUser1;
     Args.pvUser2 = pvUser2;
-    Args.idCpu = RTMpCpuId(); /** @todo should disable pre-emption before doing this.... */
+    Args.idCpu = RTMpCpuId();
     Args.cHits = 0;
-
-    /* HERE JOE - this looks broken, explain to Knut */
-    vbi_preempt_disable();
 
     vbi_execute_on_others(rtmpOnOthersSolarisWrapper, &Args);
@@ -259 +259 @@
     Args.cHits = 0;
 
-    /* TBD HERE JOE again.. perhaps broken */
     vbi_preempt_disable();