Changeset 19450 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

May 6, 2009 6:08:58 PM (16 years ago)

Author:

vboxsync

Message:

VMMAll: updated SIPI sketch.

File:

• trunk/src/VBox/VMM/VMMAll/VMMAll.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/VMMAll.cpp

@@ -80 +80 @@
  * @param   pVM         The VM to operate on.
  * @param   idCpu       Virtual CPU to perform SIPI on
- * @param   iVector     SIPI vector
- */
-DECLCALLBACK(int) vmmR3SendSipi(PVM pVM, VMCPUID idCpu, int iVector)
+ * @param   uVector     SIPI vector
+ */
+DECLCALLBACK(int) vmmR3SendSipi(PVM pVM, VMCPUID idCpu, uint32_t uVector)
 {
     PVMCPU pVCpu = VMMGetCpuById(pVM, idCpu);
@@ -88 +88 @@
 
     /** @todo what are we supposed to do if the processor is already running? */
+    CPUMSetGuestCS(pVCpu, uVector * 0x100);
+    CPUMSetGuestEIP(pVCpu, 0);
+
+# if 1 /* If we keep the EMSTATE_WAIT_SIPI method, then move this to EM.cpp. */
+    return VINF_EM_RESCHEDULE;
+# else /* And if we go the VMCPU::enmState way it can stay here. */
     VMCPU_ASSERT_STATE(pVCpu, VMCPUSTATE_STOPPED);
     VMCPU_SET_STATE(pVCpu, VMCPUSTATE_STARTED);
-
-    CPUMSetGuestCS(pVCpu, iVector * 0x100);
-    CPUMSetGuestEIP(pVCpu, 0);
     return VINF_SUCCESS;
+# endif
 }
 #endif /* IN_RING3 */
@@ -113 +117 @@
     PVMREQ pReq;
     int rc = VMR3ReqCallU(pVM->pUVM, idCpu, &pReq, RT_INDEFINITE_WAIT, 0,
-                          (PFNRT)vmmR3SendSipi, 3, pVM, idCpu, iVector);
+                          (PFNRT)vmmR3SendSipi, 3, pVM, idCpu, (uint32_t)iVector);
     AssertRC(rc);
     VMR3ReqFree(pReq);