Changeset 19668 in vbox

Timestamp:

May 13, 2009 3:57:19 PM (16 years ago)

Author:

vboxsync

Message:

vmmR3ServiceCallHostRequest: check for pending pdm critical section releases (deadlock).

File:

• trunk/src/VBox/VMM/VMM.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMM.cpp

@@ -60 +60 @@
 #include <VBox/cfgm.h>
 #include <VBox/pdmqueue.h>
+#include <VBox/pdmcritsect.h>
 #include <VBox/pdmapi.h>
 #include <VBox/cpum.h>
@@ -1524 +1525 @@
 static int vmmR3ServiceCallHostRequest(PVM pVM, PVMCPU pVCpu)
 {
+    /* We must also check for pending releases or else we can deadlock when acquiring a new lock here. 
+     * On return we go straight back to R0/GC.
+     */
+    if (VMCPU_FF_ISPENDING(pVCpu, VMCPU_FF_PDM_CRITSECT))
+        PDMR3CritSectFF(pVCpu);
+
     switch (pVCpu->vmm.s.enmCallHostOperation)
     {