Changeset 19680 in vbox

Timestamp:

May 14, 2009 9:20:06 AM (16 years ago)

Author:

vboxsync

Message:

More locking

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp (modified) (8 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -2670 +2670 @@
 int pgmPoolTrackFlushGCPhys(PVM pVM, PPGMPAGE pPhysPage, bool *pfFlushTLBs)
 {
+    pgmLock(pVM);
     int rc = VINF_SUCCESS;
 #ifdef PGMPOOL_WITH_GCPHYS_TRACKING
@@ -2742 +2743 @@
         rc = VINF_PGM_SYNC_CR3;
     }
-
+    pgmUnlock(pVM);
     return rc;
 }
@@ -3153 +3154 @@
 uint16_t pgmPoolTrackPhysExtAddref(PVM pVM, uint16_t u16, uint16_t iShwPT)
 {
+    pgmLock(pVM);
     if (PGMPOOL_TD_GET_CREFS(u16) != PGMPOOL_TD_CREFS_PHYSEXT)
     {
@@ -3181 +3183 @@
     else
         STAM_COUNTER_INC(&pVM->pgm.s.StatTrackAliasedLots);
+    pgmUnlock(pVM);
     return u16;
 }
@@ -3200 +3203 @@
     if (iPhysExt != PGMPOOL_TD_IDX_OVERFLOWED)
     {
+        PVM pVM = pPool->CTX_SUFF(pVM);
+        pgmLock(pVM);
+
         uint16_t        iPhysExtPrev = NIL_PGMPOOL_PHYSEXT_INDEX;
         PPGMPOOLPHYSEXT paPhysExts = pPool->CTX_SUFF(paPhysExts);
@@ -3219 +3225 @@
                         {
                             Log2(("pgmPoolTrackPhysExtDerefGCPhys: pPhysPage=%R[pgmpage] idx=%d\n", pPhysPage, pPage->idx));
+                            pgmUnlock(pVM);
                             return;
                         }
 
                     /* we can free the node. */
-                    PVM pVM = pPool->CTX_SUFF(pVM);
                     const uint16_t iPhysExtNext = paPhysExts[iPhysExt].iNext;
                     if (    iPhysExtPrev == NIL_PGMPOOL_PHYSEXT_INDEX
@@ -3248 +3254 @@
                     }
                     iPhysExt = iPhysExtNext;
+                    pgmUnlock(pVM);
                     return;
                 }
@@ -3257 +3264 @@
         } while (iPhysExt != NIL_PGMPOOL_PHYSEXT_INDEX);
 
+        pgmUnlock(pVM);
         AssertFatalMsgFailed(("not-found! cRefs=%d pPhysPage=%R[pgmpage] pPage=%p:{.idx=%d}\n", cRefs, pPhysPage, pPage, pPage->idx));
     }