Changeset 19691 in vbox for trunk

Timestamp:

May 14, 2009 12:10:15 PM (16 years ago)

Author:

vboxsync

Message:

SyncPT must be protected by a lock.

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllBth.h (modified) (5 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -258 +258 @@
         STAM_PROFILE_START(&pVCpu->pgm.s.StatRZTrap0eTimeSyncPT, f);
         LogFlow(("=>SyncPT %04x = %08x\n", iPDSrc, PdeSrc.au32[0]));
+        pgmLock(pVM);
         rc = PGM_BTH_NAME(SyncPT)(pVCpu, iPDSrc, pPDSrc, pvFault);
+        pgmUnlock(pVM);
         if (RT_SUCCESS(rc))
         {
@@ -1161 +1163 @@
             Assert(pgmMapAreMappingsEnabled(&pVM->pgm.s));
             Assert(PGMGetGuestMode(pVCpu) <= PGMMODE_PAE);
+            pgmLock(pVM);
             rc = PGM_BTH_NAME(SyncPT)(pVCpu, iPDSrc, pPDSrc, GCPtrPage);
+            pgmUnlock(pVM);
         }
         else if (   PdeSrc.n.u1User != PdeDst.n.u1User
@@ -2372 +2376 @@
     LogFlow(("SyncPT: GCPtrPage=%RGv\n", GCPtrPage));
 
+    Assert(PGMIsLocked(pVM));
+
 #if   (   PGM_GST_TYPE == PGM_TYPE_32BIT  \
        || PGM_GST_TYPE == PGM_TYPE_PAE    \
@@ -3012 +3018 @@
         {
             if (!PdeDst.n.u1Present)
+            {
+                PVM pVM = pVCpu->CTX_SUFF(pVM);
                 /** r=bird: This guy will set the A bit on the PDE, probably harmless. */
+                pgmLock(pVM);
                 rc = PGM_BTH_NAME(SyncPT)(pVCpu, iPDSrc, pPDSrc, GCPtrPage);
+                pgmUnlock(pVM);
+            }
             else
             {
@@ -3158 +3169 @@
     if (!pPdeDst->n.u1Present)
     {
+        pgmLock(pVM);
         rc = PGM_BTH_NAME(SyncPT)(pVCpu, iPDSrc, pPDSrc, GCPtrPage);
+        pgmUnlock(pVM);
         AssertRC(rc);
         if (rc != VINF_SUCCESS)