Changeset 19903 in vbox

Timestamp:

May 22, 2009 9:41:32 AM (16 years ago)

Author:

vboxsync

Message:

Invalidation cleanup

Location:

trunk

Files:

• include/VBox/hwacc_svm.h (modified) (1 diff)
• include/VBox/hwaccm.h (modified) (2 diffs)
• src/VBox/VMM/PGMInternal.h (modified) (4 diffs)
• src/VBox/VMM/VMMAll/HWACCMAll.cpp (modified) (4 diffs)
• src/VBox/VMM/VMMAll/PGMAllHandler.cpp (modified) (7 diffs)
• src/VBox/VMM/VMMAll/PGMAllPool.cpp (modified) (3 diffs)
• src/VBox/VMM/VMMAll/PGMAllShw.h (modified) (1 diff)
• src/VBox/VMM/VMMR0/HWSVMR0.cpp (modified) (2 diffs)

trunk/include/VBox/hwacc_svm.h

@@ -669 +669 @@
 #ifdef IN_RING0
 VMMR0DECL(int) SVMR0InvalidatePage(PVM pVM, PVMCPU pVCpu, RTGCPTR GCVirt);
-VMMR0DECL(int) SVMR0InvalidatePhysPage(PVM pVM, PVMCPU pVCpu, RTGCPHYS GCPhys);
 #endif /* IN_RING0 */
 

trunk/include/VBox/hwaccm.h

@@ -81 +81 @@
 #ifndef IN_RC
 VMMDECL(int)     HWACCMFlushTLB(PVMCPU pVCpu);
-VMMDECL(int)     HWACCMFlushAllTLBs(PVM pVM);
-VMMDECL(int)     HWACCMInvalidatePhysPage(PVMCPU pVCpu, RTGCPHYS GCPhys);
+VMMDECL(int)     HWACCMFlushTLBOnAllVCpus(PVM pVM);
+VMMDECL(int)     HWACCMInvalidatePageOnAllVCpus(PVM pVM, RTGCPTR GCVirt);
+VMMDECL(int)     HWACCMInvalidatePhysPage(PVM pVM, RTGCPHYS GCPhys);
 VMMDECL(bool)    HWACCMIsNestedPagingActive(PVM pVM);
 VMMDECL(PGMMODE) HWACCMGetShwPagingMode(PVM pVM);
@@ -89 +90 @@
 # define HWACCMFlushTLB(pVCpu)                  do { } while (0)
 # define HWACCMIsNestedPagingActive(pVM)        false
-# define HWACCMFlushAllTLBs(pVM)                do { } while (0)
+# define HWACCMFlushTLBOnAllVCpus(pVM)          do { } while (0)
 #endif
 

trunk/src/VBox/VMM/PGMInternal.h

@@ -327 +327 @@
 
 /** @def PGM_INVL_PG
- * Invalidates a page when in GC does nothing in HC.
- *
+ * Invalidates a page.
+ *
+ * @param   pVCpu       The VMCPU handle.
  * @param   GCVirt      The virtual address of the page to invalidate.
  */
@@ -339 +340 @@
 #endif
 
+/** @def PGM_INVL_PG
+ * Invalidates a page on all VCPUs
+ *
+ * @param   pVM         The VM handle.
+ * @param   GCVirt      The virtual address of the page to invalidate.
+ */
+#ifdef IN_RC
+# define PGM_INVL_ALL_VCPU_PG(pVM, GCVirt)      ASMInvalidatePage((void *)(GCVirt))
+#elif defined(IN_RING0)
+# define PGM_INVL_ALL_VCPU_PG(pVM, GCVirt)      HWACCMInvalidatePageOnAllVCpus(pVM, (RTGCPTR)(GCVirt))
+#else
+# define PGM_INVL_ALL_VCPU_PG(pVM, GCVirt)      HWACCMInvalidatePageOnAllVCpus(pVM, (RTGCPTR)(GCVirt))
+#endif
+
 /** @def PGM_INVL_BIG_PG
- * Invalidates a 4MB page directory entry when in GC does nothing in HC.
- *
+ * Invalidates a 4MB page directory entry.
+ *
+ * @param   pVCpu       The VMCPU handle.
  * @param   GCVirt      The virtual address within the page directory to invalidate.
  */
@@ -354 +370 @@
 /** @def PGM_INVL_VCPU_TLBS()
  * Invalidates the TLBs of the specified VCPU
+ *
+ * @param   pVCpu       The VMCPU handle.
  */
 #ifdef IN_RC
@@ -365 +383 @@
 /** @def PGM_INVL_ALL_VCPU_TLBS()
  * Invalidates the TLBs of all VCPUs
+ *
+ * @param   pVM         The VM handle.
  */
 #ifdef IN_RC
 # define PGM_INVL_ALL_VCPU_TLBS(pVM)            ASMReloadCR3()
 #elif defined(IN_RING0)
-# define PGM_INVL_ALL_VCPU_TLBS(pVM)            HWACCMFlushAllTLBs(pVM)
+# define PGM_INVL_ALL_VCPU_TLBS(pVM)            HWACCMFlushTLBOnAllVCpus(pVM)
 #else
-# define PGM_INVL_ALL_VCPU_TLBS(pVM)            HWACCMFlushAllTLBs(pVM)
+# define PGM_INVL_ALL_VCPU_TLBS(pVM)            HWACCMFlushTLBOnAllVCpus(pVM)
 #endif
 

trunk/src/VBox/VMM/VMMAll/HWACCMAll.cpp

@@ -75 +75 @@
     LogFlow(("HWACCMFlushTLB\n"));
 
-    pVCpu->hwaccm.s.fForceTLBFlush = true;
+    VMCPU_FF_SET(pVCpu, VMCPU_FF_TLB_FLUSH);
     STAM_COUNTER_INC(&pVCpu->hwaccm.s.StatFlushTLBManual);
     return VINF_SUCCESS;
@@ -82 +82 @@
 #ifndef IN_RC
 /**
+ * Invalidates a guest page on all VCPUs.
+ *
+ * @returns VBox status code.
+ * @param   pVM         The VM to operate on.
+ * @param   GCVirt      Page to invalidate
+ */
+VMMDECL(int) HWACCMInvalidatePageOnAllVCpus(PVM pVM, RTGCPTR GCPtr)
+{
+    /* @todo */
+    HWACCMInvalidatePage(VMMGetCpu(pVM), GCPtr);
+    return VINF_SUCCESS;
+}
+
+/**
  * Flush the TLBs of all VCPUs
  *
@@ -87 +101 @@
  * @param   pVM       The VM to operate on.
  */
-VMMDECL(int) HWACCMFlushAllTLBs(PVM pVM)
+VMMDECL(int) HWACCMFlushTLBOnAllVCpus(PVM pVM)
 {
     if (pVM->cCPUs == 1)
@@ -153 +167 @@
  *
  * @returns VBox status code.
- * @param   pVCpu       The VMCPU to operate on.
+ * @param   pVM         The VM to operate on.
  * @param   GCPhys      Page to invalidate
  */
-VMMDECL(int) HWACCMInvalidatePhysPage(PVMCPU pVCpu, RTGCPHYS GCPhys)
-{
-    PVM pVM = pVCpu->CTX_SUFF(pVM);
-
+VMMDECL(int) HWACCMInvalidatePhysPage(PVM pVM, RTGCPHYS GCPhys)
+{
     if (!HWACCMIsNestedPagingActive(pVM))
         return VINF_SUCCESS;
 
+    PVMCPU pVCpu = VMMGetCpu(pVM);
 #ifdef IN_RING0
     if (pVM->hwaccm.s.vmx.fSupported)
+    {
+        /* @todo for all vcpus */
         return VMXR0InvalidatePhysPage(pVM, pVCpu, GCPhys);
+    }
 
     Assert(pVM->hwaccm.s.svm.fSupported);
-    SVMR0InvalidatePhysPage(pVM, pVCpu, GCPhys);
+    HWACCMFlushTLBOnAllVCpus(pVM);
 #else
-    HWACCMFlushTLB(pVCpu);
+    HWACCMFlushTLBOnAllVCpus(pVM);
 #endif
     return VINF_SUCCESS;

trunk/src/VBox/VMM/VMMAll/PGMAllHandler.cpp

@@ -169 +169 @@
         pVM->pgm.s.fPhysCacheFlushPending = true;
         pgmUnlock(pVM);
-        HWACCMFlushAllTLBs(pVM);
+        HWACCMFlushTLBOnAllVCpus(pVM);
 #ifndef IN_RING3
         REMNotifyHandlerPhysicalRegister(pVM, enmType, GCPhys, GCPhysLast - GCPhys + 1, !!pfnHandlerR3);
@@ -271 +271 @@
         pgmHandlerPhysicalDeregisterNotifyREM(pVM, pCur);
         pgmUnlock(pVM);
-        HWACCMFlushAllTLBs(pVM);
+        HWACCMFlushTLBOnAllVCpus(pVM);
         MMHyperFree(pVM, pCur);
         return VINF_SUCCESS;
@@ -417 +417 @@
         PGM_INVL_VCPU_TLBS(VMMGetCpu0(pVM));
 # else
-    HWACCMFlushAllTLBs(pVM);
+    HWACCMFlushTLBOnAllVCpus(pVM);
 # endif
     pVM->pgm.s.fPhysCacheFlushPending = true;
@@ -553 +553 @@
 #endif
                     pgmUnlock(pVM);
-                    HWACCMFlushAllTLBs(pVM);
+                    HWACCMFlushTLBOnAllVCpus(pVM);
                     Log(("PGMHandlerPhysicalModify: GCPhysCurrent=%RGp -> GCPhys=%RGp GCPhysLast=%RGp\n",
                          GCPhysCurrent, GCPhys, GCPhysLast));
@@ -848 +848 @@
                     rc = pgmHandlerPhysicalSetRamFlagsAndFlushShadowPTs(pVM, pCur, pRam);
                     pVM->pgm.s.fPhysCacheFlushPending = true;
-                    HWACCMFlushAllTLBs(pVM);
+                    HWACCMFlushTLBOnAllVCpus(pVM);
                 }
 
@@ -920 +920 @@
             PGM_PAGE_SET_HNDL_PHYS_STATE(pPage, PGM_PAGE_HNDL_PHYS_STATE_DISABLED);
 #ifndef IN_RC
-            HWACCMInvalidatePhysPage(VMMGetCpu(pVM), GCPhysPage);
+            HWACCMInvalidatePhysPage(pVM, GCPhysPage);
 #endif
             return VINF_SUCCESS;
@@ -1037 +1037 @@
 
 #ifndef IN_RC
-            HWACCMInvalidatePhysPage(VMMGetCpu(pVM), GCPhysPage);
+            HWACCMInvalidatePhysPage(pVM, GCPhysPage);
 #endif
             return VINF_SUCCESS;

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -1297 +1297 @@
      */
     int rc = pgmPoolFlushPage(pPool, pPage);
+    /* This flush was initiated by us and not the guest, so explicitly flush the TLB. */
     if (rc == VINF_SUCCESS)
-        PGM_INVL_VCPU_TLBS(VMMGetCpu(pVM)); /* see PT handler. */
+        PGM_INVL_ALL_VCPU_TLBS(pVM);
     return rc;
 }
@@ -3963 +3964 @@
 static int pgmPoolMakeMoreFreePages(PPGMPOOL pPool, PGMPOOLKIND enmKind, uint16_t iUser)
 {
+    PVM pVM = pPool->CTX_SUFF(pVM);
+
     LogFlow(("pgmPoolMakeMoreFreePages: iUser=%#x\n", iUser));
 
@@ -3978 +3981 @@
         STAM_PROFILE_ADV_SUSPEND(&pPool->StatAlloc, a);
 #ifdef IN_RING3
-        int rc = PGMR3PoolGrow(pPool->pVMR3);
+        int rc = PGMR3PoolGrow(pVM);
 #else
-        int rc = CTXALLMID(VMM, CallHost)(pPool->CTX_SUFF(pVM), VMMCALLHOST_PGM_POOL_GROW, 0);
+        int rc = CTXALLMID(VMM, CallHost)(pVM, VMMCALLHOST_PGM_POOL_GROW, 0);
 #endif
         if (RT_FAILURE(rc))

trunk/src/VBox/VMM/VMMAll/PGMAllShw.h

@@ -363 +363 @@
                 Assert(pPT->a[iPTE].n.u1Present);
 # if PGM_SHW_TYPE == PGM_TYPE_EPT
-                HWACCMInvalidatePhysPage(pVCpu, (RTGCPHYS)GCPtr);
+                HWACCMInvalidatePhysPage(pVM, (RTGCPHYS)GCPtr);
 # else
-                PGM_INVL_PG(pVCpu, GCPtr);
+                PGM_INVL_ALL_VCPU_PG(pVM, GCPtr);
 # endif
             }

trunk/src/VBox/VMM/VMMR0/HWSVMR0.cpp

@@ -2352 +2352 @@
 
 
+#if 0 /* obsolete, but left here for clarification. */
 /**
  * Invalidates a guest page by physical address
@@ -2368 +2369 @@
     return VINF_SUCCESS;
 }
+#endif
 
 #if HC_ARCH_BITS == 32 && defined(VBOX_ENABLE_64_BITS_GUESTS) && !defined(VBOX_WITH_HYBRID_32BIT_KERNEL)