Changeset 19940 in vbox for trunk

Timestamp:

May 23, 2009 2:17:33 PM (16 years ago)

Author:

vboxsync

Message:

tstR0ThreadPreemption: fixes.

Location:

trunk/src/VBox/Runtime/testcase

Files:

• tstR0ThreadPreemption.cpp (modified) (5 diffs)
• tstR0ThreadPreemptionDriver.cpp (modified) (4 diffs)

trunk/src/VBox/Runtime/testcase/tstR0ThreadPreemption.cpp

@@ -79 +79 @@
         {
             RTTHREADPREEMPTSTATE State = RTTHREADPREEMPTSTATE_INITIALIZER;
+            if (!RTThreadPreemptIsEnabled(NIL_RTTHREAD))
+                RTStrPrintf(pszErr, cchErr, "RTThreadPreemptIsEnabled returns false by default");
             RTThreadPreemptDisable(&State);
             if (RTThreadPreemptIsEnabled(NIL_RTTHREAD))
@@ -108 +110 @@
                              && cNanosElapsed < UINT64_C(60)*1000U*1000U*1000U);
                     if (!fPending)
-                        RTStrPrintf(pszErr, cchErr, "!Preempt not pending after %llu loops / %llu ns\n",
+                        RTStrPrintf(pszErr, cchErr, "!Preempt not pending after %llu loops / %llu ns",
                                     cLoops, cNanosElapsed);
                     else if (cLoops == 1)
                         RTStrPrintf(pszErr, cchErr, "!cLoops=0\n");
                     else
-                        RTStrPrintf(pszErr, cchErr, "RTThreadPreemptIsPending returned true after %llu loops / %llu ns\n",
+                        RTStrPrintf(pszErr, cchErr, "RTThreadPreemptIsPending returned true after %llu loops / %llu ns",
                                     cLoops, cNanosElapsed);
                 }
@@ -127 +129 @@
         case TSTR0THREADPREMEPTION_NESTED:
         {
+            bool const fDefault = RTThreadPreemptIsEnabled(NIL_RTTHREAD);
             RTTHREADPREEMPTSTATE State1 = RTTHREADPREEMPTSTATE_INITIALIZER;
             RTThreadPreemptDisable(&State1);
@@ -154 +157 @@
                 RTStrPrintf(pszErr, cchErr, "!RTThreadPreemptIsEnabled returns true after 1st RTThreadPreemptDisable");
             RTThreadPreemptRestore(&State1);
-            if (!RTThreadPreemptIsEnabled(NIL_RTTHREAD) && !*pszErr)
+            if (RTThreadPreemptIsEnabled(NIL_RTTHREAD) != fDefault && !*pszErr)
                 RTStrPrintf(pszErr, cchErr, "!RTThreadPreemptIsEnabled returns false after 3rd RTThreadPreemptRestore");
             break;
@@ -160 +163 @@
 
         default:
-            RTStrPrintf(pszErr, cchErr, "!Unknown test #%d\n", uOperation);
+            RTStrPrintf(pszErr, cchErr, "!Unknown test #%d", uOperation);
             break;
     }

trunk/src/VBox/Runtime/testcase/tstR0ThreadPreemptionDriver.cpp

@@ -144 +144 @@
     if (RT_FAILURE(rc))
         return RTTestSummaryAndDestroy(hTest);
-    RTTESTI_CHECK_MSG(Req.szMsg[0] == '\0', ("%s", Req.szMsg));
     if (Req.szMsg[0] == '!')
+    {    
+        RTTestIFailed("%s", &Req.szMsg[1]);
         return RTTestSummaryAndDestroy(hTest);
+    }
     if (Req.szMsg[0])
         RTTestIPrintf(RTTESTLVL_ALWAYS, "%s", Req.szMsg);
@@ -164 +166 @@
             ||  i >= 64)
         {
-            RTTESTI_CHECK_MSG(Req.szMsg[0] != '!', ("%s", Req.szMsg));
-            if (Req.szMsg[0])
+            if (Req.szMsg[0] == '!')
+                RTTestIFailed("%s", &Req.szMsg[1]);
+            else if (Req.szMsg[0])
                 RTTestIPrintf(RTTESTLVL_ALWAYS, "%s", Req.szMsg);
             break;
@@ -182 +185 @@
     RTTESTI_CHECK_RC(rc = SUPR3CallR0Service("tstR0ThreadPreemption", sizeof("tstR0ThreadPreemption") - 1,
                                              TSTR0THREADPREMEPTION_NESTED, 0, &Req.Hdr), VINF_SUCCESS);
-    RTTESTI_CHECK_MSG(Req.szMsg[0] != '!', ("%s", Req.szMsg));
-    if (Req.szMsg[0])
+    if (Req.szMsg[0] == '!')
+        RTTestIFailed("%s", &Req.szMsg[1]);
+    else if (Req.szMsg[0])
         RTTestIPrintf(RTTESTLVL_ALWAYS, "%s", Req.szMsg);
-
-
 
     /*
@@ -194 +196 @@
 #endif
 }
+