Changeset 20003 in vbox

Timestamp:

May 25, 2009 2:38:49 PM (16 years ago)

Author:

vboxsync

Message:

Enabled the IO-APIC optimizations for VT-x in the 32 bits guest case. (both nested and normal shadow paging)

File:

• trunk/src/VBox/VMM/VMMR0/HWVMXR0.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/VMMR0/HWVMXR0.cpp

@@ -2484 +2484 @@
                 TRPMSetFaultAddress(pVCpu, exitQualification);
 
+                /* Shortcut for APIC TPR reads and writes; 32 bits guests only */
+                if (    (exitQualification & 0xfff) == 0x080
+                    &&  !(errCode & X86_TRAP_PF_P)  /* not present */
+                    &&  fSetupTPRCaching
+                    &&  !CPUMIsGuestInLongModeEx(pCtx))
+                {
+                    RTGCPHYS GCPhysApicBase, GCPhys;
+                    PDMApicGetBase(pVM, &GCPhysApicBase);   /* @todo cache this */
+                    GCPhysApicBase &= PAGE_BASE_GC_MASK;
+
+                    rc = PGMGstGetPage(pVCpu, (RTGCPTR)exitQualification, NULL, &GCPhys);
+                    if (    rc == VINF_SUCCESS
+                        &&  GCPhys == GCPhysApicBase)
+                    {
+                        Log(("Enable VT-x virtual APIC access filtering\n"));
+                        pVCpu->hwaccm.s.vmx.proc_ctls2 |= VMX_VMCS_CTRL_PROC_EXEC2_VIRT_APIC;
+                        rc = VMXWriteVMCS(VMX_VMCS_CTRL_PROC_EXEC_CONTROLS2, pVCpu->hwaccm.s.vmx.proc_ctls2);
+                        AssertRC(rc);
+
+                        rc = IOMMMIOMapMMIOHCPage(pVM, GCPhysApicBase, pVM->hwaccm.s.vmx.pAPICPhys, X86_PTE_RW | X86_PTE_P);
+                        AssertRC(rc);
+                    }
+                }
+
                 /* Forward it to our trap handler first, in case our shadow pages are out of sync. */
                 rc = PGMTrap0eHandler(pVCpu, errCode, CPUMCTX2CORE(pCtx), (RTGCPTR)exitQualification);
@@ -2941 +2965 @@
             errCode |= X86_TRAP_PF_P;
         }
-#if 0
         else {
             /* Shortcut for APIC TPR reads and writes; 32 bits guests only */
@@ -2947 +2970 @@
                 &&  GCPhys > 0x1000000   /* to skip VGA frame buffer accesses */
                 &&  !CPUMIsGuestInLongModeEx(pCtx)
-                &&  (pVM->hwaccm.s.vmx.msr.vmx_proc_ctls2.n.allowed1 & VMX_VMCS_CTRL_PROC_EXEC2_VIRT_APIC))
+                &&  fSetupTPRCaching)
             {
                 RTGCPHYS GCPhysApicBase;
@@ -2964 +2987 @@
             }
         }
-#endif
         Log(("EPT Page fault %x at %RGp error code %x\n", (uint32_t)exitQualification, GCPhys, errCode));