Changeset 20026 in vbox

Timestamp:

May 26, 2009 11:41:27 AM (16 years ago)

Author:

vboxsync

Message:

Testing AMD IO-APIC patching

Location:

trunk/src/VBox/VMM

Files:

• HWACCM.cpp (modified) (1 diff)
• HWACCMInternal.h (modified) (1 diff)
• VMMR0/HWSVMR0.cpp (modified) (1 diff)
• VMMR0/HWVMXR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/HWACCM.cpp

@@ -619 +619 @@
     Assert(!pVM->fHWACCMEnabled || VMMIsHwVirtExtForced(pVM));
 
+    pVM->hwaccm.s.fHasIoApic = PDMHasIoApic(pVM);
+
     if (pVM->hwaccm.s.vmx.fSupported)
     {

trunk/src/VBox/VMM/HWACCMInternal.h

@@ -205 +205 @@
     bool                        fAllow64BitGuests;
 
+    /** Set if an IO-APIC is configured for this VM. */
+    bool                        fHasIoApic;
+
     /** Explicit alignment padding to make 32-bit gcc align u64RegisterMask
      *  naturally. */
-    bool                        padding[2];
+    bool                        padding[1];
 
     /** And mask for copying register contents. */

trunk/src/VBox/VMM/VMMR0/HWSVMR0.cpp

@@ -1453 +1453 @@
             Assert(!pVM->hwaccm.s.fNestedPaging);
 
+#if 0
+            /* Shortcut for APIC TPR reads and writes; 32 bits guests only */
+            if (    (uFaultAddress & 0xfff) == 0x080
+                &&  pVM->hwaccm.s.fHasIoApic
+                &&  !(errCode & X86_TRAP_PF_P)  /* not present */
+                &&  !CPUMIsGuestInLongModeEx(pCtx))
+            {
+                RTGCPHYS GCPhysApicBase, GCPhys;
+                PDMApicGetBase(pVM, &GCPhysApicBase);   /* @todo cache this */
+                GCPhysApicBase &= PAGE_BASE_GC_MASK;
+
+                rc = PGMGstGetPage(pVCpu, (RTGCPTR)uFaultAddress, NULL, &GCPhys);
+                if (    rc == VINF_SUCCESS
+                    &&  GCPhys == GCPhysApicBase)
+                {
+                    Log(("Replace TPR access at %RGv\n", pCtx->rip));
+
+                    DISCPUSTATE Cpu;
+                    unsigned cbOp;
+                    rc = EMInterpretDisasOne(pVM, pVCpu, CPUMCTX2CORE(pCtx), &Cpu, &cbOp);
+                    AssertRC(rc);
+                    if (    rc == VINF_SUCCESS
+                        &&  Cpu.pCurInstr->opcode == OP_MOV
+                        &&  cbOp == 6)
+                    {
+                        if (    (errCode & X86_TRAP_PF_RW)
+                            &&  Cpu.param1.parval == uFaultAddress)
+                        {
+                            Log(("Acceptable write candidate!\n"));
+                        }
+                        else
+                        if (Cpu.param2.parval == uFaultAddress)
+                        {
+                            Log(("Acceptable read candidate!\n"));
+                        }
+                    }
+
+                }
+            }
+#endif
+
             Log2(("Page fault at %RGv cr2=%RGv error code %x\n", (RTGCPTR)pCtx->rip, uFaultAddress, errCode));
             /* Exit qualification contains the linear address of the page fault. */

trunk/src/VBox/VMM/VMMR0/HWVMXR0.cpp

@@ -431 +431 @@
 #endif /* HWACCM_VTX_WITH_VPID */
 
-            if (PDMHasIoApic(pVM))
+            if (pVM->hwaccm.s.fHasIoApic)
                 val |= VMX_VMCS_CTRL_PROC_EXEC2_VIRT_APIC;
             
@@ -2017 +2017 @@
     if (    CPUMIsGuestInLongModeEx(pCtx)
         || (   (pVM->hwaccm.s.vmx.msr.vmx_proc_ctls2.n.allowed1 & VMX_VMCS_CTRL_PROC_EXEC2_VIRT_APIC)
-            && PDMHasIoApic(pVM))
+            &&  pVM->hwaccm.s.fHasIoApic)
        )
     {