SharedFolders

Timestamp:

Jun 4, 2009 3:18:47 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

48179

Message:

Corrected write-protected check for opening a file on shared folders (xTracker #3940)

File:

trunk/src/VBox/HostServices/SharedFolders/vbsf.cpp

-              r20279
+              r20292
             rc = VINF_SUCCESS;
+            /* write access requested? */
+            if (pParms->CreateFlags & (  SHFL_CF_ACT_REPLACE_IF_EXISTS
+                                       | SHFL_CF_ACT_OVERWRITE_IF_EXISTS
+                                       | SHFL_CF_ACT_CREATE_IF_NEW
+                                       | SHFL_CF_ACCESS_WRITE))
+            /* Note: do not check the SHFL_CF_ACCESS_WRITE here, only check if the open operation
+             * will cause changes.
+             *
+             * Actual operations (write, set attr, etc), which can write to a shared folder, have
+             * the check and will return VERR_WRITE_PROTECT if the folder is not writable.
+             */
+            if (   (pParms->CreateFlags & SHFL_CF_ACT_MASK_IF_EXISTS) == SHFL_CF_ACT_REPLACE_IF_EXISTS
+                || (pParms->CreateFlags & SHFL_CF_ACT_MASK_IF_EXISTS) == SHFL_CF_ACT_OVERWRITE_IF_EXISTS
+                || (pParms->CreateFlags & SHFL_CF_ACT_MASK_IF_NEW) == SHFL_CF_ACT_CREATE_IF_NEW
+               )
+            {
                 /* is the guest allowed to write to this share? */

Note: See TracChangeset for help on using the changeset viewer.