Changeset 20298 in vbox for trunk/src/VBox/Additions/linux/sharedfolders

Timestamp:

Jun 5, 2009 8:08:52 AM (16 years ago)

Author:

vboxsync

Message:

Linux shared folders: properly initialize the whole params !VBoxCall() structure including the attributes

Location:

trunk/src/VBox/Additions/linux/sharedfolders

Files:

• dirops.c (modified) (2 diffs)
• regops.c (modified) (2 diffs)
• utils.c (modified) (1 diff)

trunk/src/VBox/Additions/linux/sharedfolders/dirops.c

@@ -43 +43 @@
         }
 
+        memset(&params, 0, sizeof(params));
+
         sf_d = sf_dir_info_alloc ();
 
@@ -406 +408 @@
                 dentry->d_name.name);
 #endif
+
+        memset(&params, 0, sizeof(params));
 
         params.CreateFlags = 0

trunk/src/VBox/Additions/linux/sharedfolders/regops.c

@@ -210 +210 @@
         BUG_ON (!sf_i);
 
+        LogFunc(("open %s\n", sf_i->path->String.utf8));
+
         sf_r = kmalloc (sizeof (*sf_r), GFP_KERNEL);
         if (!sf_r) {
@@ -216 +218 @@
         }
 
-        LogFunc(("open %s\n", sf_i->path->String.utf8));
-
-        params.CreateFlags = 0;
-        params.Info.cbObject = 0;
-        /* We check this afterwards to find out if the call succeeded
-           or failed, as the API does not seem to cleanly distinguish
-           error and informational messages. */
-        params.Handle = 0;
+        memset(&params, 0, sizeof(params));
+        /* params.Handle is now 0. We check this afterwards to find out if
+         * the call succeeded or failed, as the API does not seem to cleanly
+         * distinguish error and informational messages. */
 
         if (file->f_flags & O_CREAT) {

trunk/src/VBox/Additions/linux/sharedfolders/utils.c

@@ -153 +153 @@
 
         TRACE ();
+
+        memset(&params, 0, sizeof(params));
         params.CreateFlags = SHFL_CF_LOOKUP | SHFL_CF_ACT_FAIL_IF_NEW;
         LogFunc(("calling vboxCallCreate, file %s, flags %#x\n",