Changeset 20346 in vbox

Timestamp:

Jun 5, 2009 4:22:03 PM (16 years ago)

Author:

vboxsync

Message:

Shared folders Host: don't allow to clear the READ access bit from a shared folder, otherwise the guest wouldn't be able to access this file any longer as the access is only done through a file handle

File:

• trunk/src/VBox/HostServices/SharedFolders/vbsf.cpp (modified) (3 diffs)

trunk/src/VBox/HostServices/SharedFolders/vbsf.cpp

@@ -33 +33 @@
 #include <iprt/string.h>
 #include <iprt/uni.h>
+#include <iprt/stream.h>
 #ifdef RT_OS_DARWIN
 #include <Carbon/Carbon.h>
@@ -1739 +1740 @@
         if (pSFDEntry->Attr.fMode)
         {
-            rc = RTFileSetMode((RTFILE)pHandle->file.Handle, pSFDEntry->Attr.fMode);
+            RTFMODE fMode = pSFDEntry->Attr.fMode;
+
+#ifndef RT_OS_WINDOWS
+            /* don't allow to clear the own bit, otherwise the guest wouldn't be
+             * able to access this file anymore */
+            if (fMode)
+                fMode |= RTFS_UNIX_IRUSR;
+#endif
+
+            rc = RTFileSetMode((RTFILE)pHandle->file.Handle, fMode);
             if (rc != VINF_SUCCESS)
             {
-                Log(("RTFileSetMode %x failed with %Rrc\n", pSFDEntry->Attr.fMode, rc));
+                Log(("RTFileSetMode %x failed with %Rrc\n", fMode, rc));
                 /* silent failure, because this tends to fail with e.g. windows guest & linux host */
                 rc = VINF_SUCCESS;
@@ -1748 +1758 @@
         }
     }
+    /* TODO: mode for directories */
 
     if (rc == VINF_SUCCESS)