Changeset 20458 in vbox for trunk

Timestamp:

Jun 10, 2009 8:17:58 AM (16 years ago)

Author:

vboxsync

Message:

First protect the dirty pages and then update the display. We might miss screen updates in the gues SMP case otherwise

File:

• trunk/src/VBox/Devices/Graphics/DevVGA.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA.cpp

@@ -4762 +4762 @@
 #endif /* VBOX_WITH_HGSMI */
 
+    if (pThis->fHasDirtyBits && pThis->GCPhysVRAM && pThis->GCPhysVRAM != NIL_RTGCPHYS32)
+    {
+        PGMHandlerPhysicalReset(PDMDevHlpGetVM(pDevIns), pThis->GCPhysVRAM);
+        pThis->fHasDirtyBits = false;
+    }
+    if (pThis->fRemappedVGA)
+    {
+        IOMMMIOResetRegion(PDMDevHlpGetVM(pDevIns), 0x000a0000);
+        pThis->fRemappedVGA = false;
+    }
+
     rc = vga_update_display(pThis, false);
     if (rc != VINF_SUCCESS)
@@ -4767 +4778 @@
         PDMCritSectLeave(&pThis->lock);
         return rc;
-    }
-
-    if (pThis->fHasDirtyBits && pThis->GCPhysVRAM && pThis->GCPhysVRAM != NIL_RTGCPHYS32)
-    {
-        PGMHandlerPhysicalReset(PDMDevHlpGetVM(pDevIns), pThis->GCPhysVRAM);
-        pThis->fHasDirtyBits = false;
-    }
-    if (pThis->fRemappedVGA)
-    {
-        IOMMMIOResetRegion(PDMDevHlpGetVM(pDevIns), 0x000a0000);
-        pThis->fRemappedVGA = false;
     }
     PDMCritSectLeave(&pThis->lock);
@@ -4805 +4805 @@
     AssertRC(rc);
 
-    pThis->graphic_mode = -1; /* force full update */
-
-    rc = vga_update_display(pThis, true);
-
     /* The dirty bits array has been just cleared, reset handlers as well. */
     if (pThis->GCPhysVRAM && pThis->GCPhysVRAM != NIL_RTGCPHYS32)
@@ -4819 +4815 @@
         pThis->fRemappedVGA = false;
     }
+
+    pThis->graphic_mode = -1; /* force full update */
+
+    rc = vga_update_display(pThis, true);
+
     PDMCritSectLeave(&pThis->lock);
     return rc;