Changeset 20654 in vbox

Timestamp:

Jun 17, 2009 9:31:56 AM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

48746

Message:

Do not acquire the PDM lock in PDMApicGetTPR

File:

• trunk/src/VBox/VMM/VMMAll/PDMAll.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/PDMAll.cpp

@@ -258 +258 @@
     {
         Assert(pVM->pdm.s.Apic.CTX_SUFF(pfnGetTPR));
-        pdmLock(pVM);
+        /* We don't acquire the PDM lock here as we're just reading information. Doing so causes massive
+         * contention as this function is called very often by each and every VCPU. 
+         */
         *pu8TPR = pVM->pdm.s.Apic.CTX_SUFF(pfnGetTPR)(pVM->pdm.s.Apic.CTX_SUFF(pDevIns), pVCpu->idCpu);
         if (pfPending)
             *pfPending = pVM->pdm.s.Apic.CTX_SUFF(pfnHasPendingIrq)(pVM->pdm.s.Apic.CTX_SUFF(pDevIns));
-        pdmUnlock(pVM);
         return VINF_SUCCESS;
     }