Changeset 20655 in vbox

Timestamp:

Jun 17, 2009 9:34:43 AM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

48747

Message:

Updated comments

Location:

trunk/src/VBox/VMM/VMMR0

Files:

• HWSVMR0.cpp (modified) (1 diff)
• HWVMXR0.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/HWSVMR0.cpp

@@ -976 +976 @@
 
     /* TPR caching using CR8 is only available in 64 bits mode or with 32 bits guests when X86_CPUID_AMD_FEATURE_ECX_CR8L is supported. */
-    /* Note: we can't do this in LoadGuestState as PDMApicGetTPR can jump back to ring 3 (lock)!!!!!!!! */
+    /* Note: we can't do this in LoadGuestState as PDMApicGetTPR can jump back to ring 3 (lock)!!!!!!!! 
+     * @todo query and update the TPR only when it could have been changed (mmio access)
+     */
     if (pVM->hwaccm.s.fHasIoApic)
     {

trunk/src/VBox/VMM/VMMR0/HWVMXR0.cpp

@@ -2213 +2213 @@
     /* Note: we can't do this in LoadGuestState as PDMApicGetTPR can jump back to ring 3 (lock)!!!!! */
     /**
-     * @todo reduce overhead
+     * @todo query and update the TPR only when it could have been changed (mmio access & wrmsr (x2apic))
      */
     if (fSetupTPRCaching)