Changeset 20674 in vbox

Timestamp:

Jun 17, 2009 4:04:53 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

48773

Message:

Grab the PGM lock in PGMPhysSimpleReadGCPtr

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllPhys.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllPhys.cpp

@@ -2243 +2243 @@
         return VINF_SUCCESS;
 
+    /* Take the PGM lock here, because many called functions take the lock for a very short period. That's counter-productive
+     * when many VCPUs are fighting for the lock.
+     */
+    pgmLock(pVM);
+
     /* map the 1st page */
     void const *pvSrc;
@@ -2248 +2253 @@
     int rc = PGMPhysGCPtr2CCPtrReadOnly(pVCpu, GCPtrSrc, &pvSrc, &Lock);
     if (RT_FAILURE(rc))
+    {
+        pgmUnlock(pVM);
         return rc;
+    }
 
     /* optimize for the case where access is completely within the first page. */
@@ -2256 +2264 @@
         memcpy(pvDst, pvSrc, cb);
         PGMPhysReleasePageMappingLock(pVM, &Lock);
+        pgmUnlock(pVM);
         return VINF_SUCCESS;
     }
@@ -2274 +2283 @@
         rc = PGMPhysGCPtr2CCPtrReadOnly(pVCpu, GCPtrSrc, &pvSrc, &Lock);
         if (RT_FAILURE(rc))
+        {
+            pgmUnlock(pVM);
             return rc;
+        }
 
         /* last page? */
@@ -2281 +2293 @@
             memcpy(pvDst, pvSrc, cb);
             PGMPhysReleasePageMappingLock(pVM, &Lock);
+            pgmUnlock(pVM);
             return VINF_SUCCESS;
         }