Changeset 20718 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Jun 19, 2009 12:05:50 PM (16 years ago)

Author:

vboxsync

Message:

DrvNAT: r=bird: Why reset the queue counters for every item?!

File:

• trunk/src/VBox/Devices/Network/DrvNAT.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Network/DrvNAT.cpp

@@ -493 +493 @@
     Log2(("slirp_output: pu8Buf=%p cb=%#x (pThis=%p)\n%.*Rhxd\n", pu8Buf, cb, pThis, cb, pu8Buf));
 
-    STAM_COUNTER_RESET(&pThis->StatQueuePktDropped);
-    STAM_COUNTER_RESET(&pThis->StatQueuePktSent);
+    /** @todo r-bird: Why do you reset the counters every time? You won't ever count
+     *        higher than ONE then. If you want to record what happened to the last
+     *        queued item, use a U8/bool instead to two 64-bit values. */
+    //STAM_COUNTER_RESET(&pThis->StatQueuePktDropped);
+    //STAM_COUNTER_RESET(&pThis->StatQueuePktSent);
     Assert(pThis);