Changeset 21187 in vbox for trunk/src

Timestamp:

Jul 3, 2009 9:49:33 AM (16 years ago)

Author:

vboxsync

Message:

Deal with operand size and mod default values for certain instructions (mov crx, mov drx)

Location:

trunk/src/VBox/Disassembler

Files:

• DisasmCore.cpp (modified) (4 diffs)
• DisasmTables.cpp (modified) (1 diff)
• DisasmTestA.asm (modified) (1 diff)

trunk/src/VBox/Disassembler/DisasmCore.cpp

@@ -415 +415 @@
     bool fFiltered = false;
 
+    Assert(lpszCodeBlock && pOp && pCpu);
+
     // Store the opcode format string for disasmPrintf
 #ifndef DIS_CORE_ONLY
@@ -450 +452 @@
             &&  !(pCpu->prefix & PREFIX_OPSIZE))
             pCpu->opmode = CPUMODE_64BIT;
+    }
+    else
+    if (pOp->optype & OPTYPE_FORCED_32_OP_SIZE_X86)
+    {
+        /* Forced 32 bits operand size for certain instructions (mov crx, mov drx). */
+        Assert(pCpu->mode != CPUMODE_64BIT);
+        pCpu->opmode = CPUMODE_32BIT;
     }
 
@@ -1105 +1114 @@
     pCpu->ModRM.Bits.Reg = MODRM_REG(ModRM);
 
+    /* Disregard the mod bits for certain instructions (mov crx, mov drx).
+     *
+     * From the AMD manual:
+     * This instruction is always treated as a register-to-register (MOD = 11) instruction, regardless of the
+     * encoding of the MOD field in the MODR/M byte.
+     */
+    if (pOp->optype & OPTYPE_MOD_FIXED_11)
+        pCpu->ModRM.Bits.Mod = 3;
+
     if (pCpu->prefix & PREFIX_REX)
     {
@@ -1141 +1159 @@
     pCpu->ModRM.Bits.Mod = MODRM_MOD(ModRM);
     pCpu->ModRM.Bits.Reg = MODRM_REG(ModRM);
+
+    /* Disregard the mod bits for certain instructions (mov crx, mov drx).
+     *
+     * From the AMD manual:
+     * This instruction is always treated as a register-to-register (MOD = 11) instruction, regardless of the
+     * encoding of the MOD field in the MODR/M byte.
+     */
+    if (pOp->optype & OPTYPE_MOD_FIXED_11)
+        pCpu->ModRM.Bits.Mod = 3;
 
     if (pCpu->prefix & PREFIX_REX)

trunk/src/VBox/Disassembler/DisasmTables.cpp

@@ -430 +430 @@
 
     /* 2 */
-    OP("mov %Rd,%Cd",        IDX_ParseModRM,     IDX_UseModRM,   0,          OP_MOV_CR,  OP_PARM_Rd,         OP_PARM_Cd,     OP_PARM_NONE,   OPTYPE_DANGEROUS | OPTYPE_PRIVILEGED),
-    OP("mov %Rd,%Dd",        IDX_ParseModRM,     IDX_UseModRM,   0,          OP_MOV_DR,  OP_PARM_Rd,         OP_PARM_Dd,     OP_PARM_NONE,   OPTYPE_DANGEROUS | OPTYPE_PRIVILEGED),
-    OP("mov %Cd,%Rd",        IDX_ParseModRM,     IDX_UseModRM,   0,          OP_MOV_CR,  OP_PARM_Cd,         OP_PARM_Rd,     OP_PARM_NONE,   OPTYPE_DANGEROUS | OPTYPE_PRIVILEGED),
-    OP("mov %Dd,%Rd",        IDX_ParseModRM,     IDX_UseModRM,   0,          OP_MOV_DR,  OP_PARM_Dd,         OP_PARM_Rd,     OP_PARM_NONE,   OPTYPE_DANGEROUS | OPTYPE_PRIVILEGED),
+    OP("mov %Rd,%Cd",        IDX_ParseModRM,     IDX_UseModRM,   0,          OP_MOV_CR,  OP_PARM_Rd,         OP_PARM_Cd,     OP_PARM_NONE,   OPTYPE_DANGEROUS | OPTYPE_PRIVILEGED | OPTYPE_MOD_FIXED_11 | OPTYPE_FORCED_32_OP_SIZE_X86),
+    OP("mov %Rd,%Dd",        IDX_ParseModRM,     IDX_UseModRM,   0,          OP_MOV_DR,  OP_PARM_Rd,         OP_PARM_Dd,     OP_PARM_NONE,   OPTYPE_DANGEROUS | OPTYPE_PRIVILEGED | OPTYPE_MOD_FIXED_11 | OPTYPE_FORCED_32_OP_SIZE_X86),
+    OP("mov %Cd,%Rd",        IDX_ParseModRM,     IDX_UseModRM,   0,          OP_MOV_CR,  OP_PARM_Cd,         OP_PARM_Rd,     OP_PARM_NONE,   OPTYPE_DANGEROUS | OPTYPE_PRIVILEGED | OPTYPE_MOD_FIXED_11 | OPTYPE_FORCED_32_OP_SIZE_X86),
+    OP("mov %Dd,%Rd",        IDX_ParseModRM,     IDX_UseModRM,   0,          OP_MOV_DR,  OP_PARM_Dd,         OP_PARM_Rd,     OP_PARM_NONE,   OPTYPE_DANGEROUS | OPTYPE_PRIVILEGED | OPTYPE_MOD_FIXED_11 | OPTYPE_FORCED_32_OP_SIZE_X86),
     /* only valid for Pentium Pro & Pentium II */
     OP("mov %Rd,%Td",        IDX_ParseModRM,     IDX_UseModRM,   0,          OP_MOV_TR,  OP_PARM_Rd,         OP_PARM_Td,     OP_PARM_NONE,   OPTYPE_PRIVILEGED),

trunk/src/VBox/Disassembler/DisasmTestA.asm

@@ -34 +34 @@
 align 16
 BEGINPROC   TestProc
+    xor eax, eax
+    mov al, 4
+    lea edx, [4]
+    mov edx, 4
+    mov eax, 4
+    shl eax, 4
+    shl edx, 4
+    shr edx, 4
+    mov eax, edx
+    mov eax, ecx
+    mov edx, eax
+    mov ecx, eax
     DB 0xF0, 0x0F, 0x22, 0xC0
     DB 0xF0, 0x0F, 0x20, 0xC0