Changeset 21507 in vbox for trunk/src/VBox/HostServices

Timestamp:

Jul 10, 2009 11:54:57 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

49957

Message:

GuestProperties/service.cpp: r=bird: todo that *needs* fixing.

File:

• trunk/src/VBox/HostServices/GuestProperties/service.cpp (modified) (1 diff)

trunk/src/VBox/HostServices/GuestProperties/service.cpp

@@ -938 +938 @@
         || RT_FAILURE(paParms[0].getPointer ((void **) &pszPatterns, &cchPatterns))  /* patterns */
         || pszPatterns[cchPatterns - 1] != '\0'  /* The patterns string must be zero-terminated */
+/** @todo r=bird: What if cchPatterns is 0? pszPatterns is NULL then, and if it wasn't, you'd access memory
+ * before what it points to. Add a getString() method? Please, check *all* similar cases.
+ * Remember that the guest is not trusted. :-) */
         || RT_FAILURE(paParms[1].getUInt64 (&u64Timestamp))  /* timestamp */
         || RT_FAILURE(paParms[2].getPointer ((void **) &pchBuf, &cchBuf))  /* return buffer */