Changeset 21522 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Jul 13, 2009 8:46:12 AM (16 years ago)

Author:

vboxsync

Message:

PCNet: Don't flood the release log with errors

File:

• trunk/src/VBox/Devices/Network/DevPCNet.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Network/DevPCNet.cpp

@@ -259 +259 @@
     RCPTRTYPE(PPCNETGUESTSHAREDMEMORY)  pSharedMMIORC;
 
-#if HC_ARCH_BITS == 64
-    uint32_t                            Alignment6;
-#endif
+    /** Error counter for bad receive descriptors. */
+    uint32_t                            uCntBadRMD;
 
     /** True if host and guest admitted to use the private interface. */
@@ -1724 +1723 @@
             {
                 STAM_PROFILE_ADV_STOP(&pThis->CTXSUFF(StatRdtePoll), a);
-                /* This is not problematic since we don't own the descriptor */
-                LogRel(("PCNet#%d: BAD RMD ENTRIES AT %#010x (i=%d)\n",
-                        PCNET_INST_NR, addr, i));
+                /* This is not problematic since we don't own the descriptor
+                 * We actually do own it, otherwise pcnetRmdLoad would have returned false.
+                 * Don't flood the release log with errors.
+                 */
+                if (++pThis->uCntBadRMD < 50)
+                    LogRel(("PCNet#%d: BAD RMD ENTRIES AT %#010x (i=%d)\n",
+                            PCNET_INST_NR, addr, i));
                 return;
             }
@@ -1754 +1757 @@
         {
             STAM_PROFILE_ADV_STOP(&pThis->CTXSUFF(StatRdtePoll), a);
-            /* This is not problematic since we don't own the descriptor */
-            LogRel(("PCNet#%d: BAD RMD ENTRIES + AT %#010x (i=%d)\n",
-                    PCNET_INST_NR, addr, i));
+            /* This is not problematic since we don't own the descriptor
+             * We actually do own it, otherwise pcnetRmdLoad would have returned false.
+             * Don't flood the release log with errors.
+             */
+            if (++pThis->uCntBadRMD < 50)
+                LogRel(("PCNet#%d: BAD RMD ENTRIES + AT %#010x (i=%d)\n",
+                        PCNET_INST_NR, addr, i));
             return;
         }
@@ -3195 +3202 @@
     pThis->aBCR[BCR_PCISVID] = PCIDevGetSubSystemVendorId(&pThis->PciDev);
 
+    /* Reset the error counter. */
+    pThis->uCntBadRMD      = 0;
+
     pcnetSoftReset(pThis);
 }