Changeset 21533 in vbox for trunk/src/VBox/Runtime

Timestamp:

Jul 13, 2009 2:39:34 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

50006

Message:

semfastmutex-generic.cpp: fixed leak in error path. @todo about no-nesting.

Location:

trunk/src/VBox/Runtime/generic

Files:

• critsect-generic.cpp (modified) (1 diff)
• semfastmutex-generic.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/generic/critsect-generic.cpp

@@ -473 +473 @@
     pCritSect->NativeThreadOwner= NIL_RTNATIVETHREAD;
     RTSEMEVENT EventSem = pCritSect->EventSem;
-    pCritSect->EventSem         = NULL;
+    pCritSect->EventSem         = NIL_RTSEMEVENT;
     while (pCritSect->cLockers-- >= 0)
         RTSemEventSignal(EventSem);

trunk/src/VBox/Runtime/generic/semfastmutex-generic.cpp

@@ -49 +49 @@
     int rc = RTCritSectInit(pCritSect);
     if (RT_SUCCESS(rc))
+    {
+        /** @todo pCritSect->fFlags |= RTCRITSECT_FLAGS_NO_NESTING; */
         *pMutexSem = (RTSEMFASTMUTEX)pCritSect;
+    }
+    else
+        RTMemFree(pCritSect);
     return rc;
 }