Changeset 22037 in vbox

Timestamp:

Aug 6, 2009 3:27:25 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

50775

Message:

VMM: correct report cores count, also expose more CPUID leaves by default

Location:

trunk

Files:

• include/VBox/vm.h (modified) (2 diffs)
• include/VBox/vm.mac (modified) (1 diff)
• src/VBox/Main/ConsoleImpl2.cpp (modified) (4 diffs)
• src/VBox/VMM/CPUM.cpp (modified) (1 diff)
• src/VBox/VMM/VM.cpp (modified) (2 diffs)
• src/VBox/VMM/VMMAll/CPUMAllRegs.cpp (modified) (3 diffs)
• src/VBox/VMM/VMMAll/EMAll.cpp (modified) (1 diff)

trunk/include/VBox/vm.h

@@ -692 +692 @@
     uint32_t                    offVMCPU;
 
+    /** Maximum CPUID leaf, exposed to this VM. */
+    uint32_t                    cCpuidLeafs;
+
     /** Reserved; alignment. */
-    uint32_t                    u32Reserved[6];
+    uint32_t                    u32Reserved[5];
 
     /** @name Public VMM Switcher APIs
@@ -1001 +1004 @@
 
 #endif
-

trunk/include/VBox/vm.mac

@@ -59 +59 @@
     .cbSelf                 resd 1
     .offVMCPU               resd 1
-    .u32Reserved            resd 6
+    .cCpuidLeafs            resd 1
+    .u32Reserved            resd 5
 
     .pfnVMMGCGuestToHostAsmGuestCtx RTRCPTR_RES 1

trunk/src/VBox/Main/ConsoleImpl2.cpp

@@ -212 +212 @@
     hrc = pMachine->COMGETTER(CPUCount)(&cCpus);                                    H();
 
+    ULONG cCpuidLeafs = 5;
+    Bstr osTypeId;
+    hrc = pMachine->COMGETTER(OSTypeId)(osTypeId.asOutParam());                     H();
+    if (osTypeId == "WindowsNT4")
+    {
+        /*
+         * We must limit CPUID count for Windows NT 4 manually,
+         * as otherwise it stops with 0x3e error
+         * (MULTIPROCESSOR_CONFIGURATION_NOT_SUPPORTED).
+         */
+        LogRel(("Limiting CPUID leaf count for NT4 guests\n"));
+        cCpuidLeafs = 2;
+    }
+
     /*
      * Get root node first.
@@ -230 +244 @@
     rc = CFGMR3InsertInteger(pRoot, "RamHoleSize",          cbRamHole);             RC_CHECK();
     rc = CFGMR3InsertInteger(pRoot, "NumCPUs",              cCpus);                 RC_CHECK();
+    rc = CFGMR3InsertInteger(pRoot, "CpuidLeafs",           cCpuidLeafs);           RC_CHECK();
     rc = CFGMR3InsertInteger(pRoot, "TimerMillies",         10);                    RC_CHECK();
     rc = CFGMR3InsertInteger(pRoot, "RawR3Enabled",         1);     /* boolean */   RC_CHECK();
@@ -266 +281 @@
          */
 
-        Bstr osTypeId;
-        hrc = pMachine->COMGETTER(OSTypeId)(osTypeId.asOutParam());                 H();
-
         ComPtr<IGuestOSType> guestOSType;
         hrc = virtualBox->GetGuestOSType(osTypeId, guestOSType.asOutParam());       H();
@@ -281 +293 @@
         {
             rc = CFGMR3InsertInteger(pHWVirtExt, "64bitEnabled", 1);                RC_CHECK();
-#if ARCH_BITS == 32 /* The recompiler must use load VBoxREM64 (32-bit host only). */
+#if ARCH_BITS == 32 /* The recompiler must use VBoxREM64 (32-bit host only). */
             PCFGMNODE pREM;
             rc = CFGMR3InsertNode(pRoot, "REM", &pREM);                             RC_CHECK();

trunk/src/VBox/VMM/CPUM.cpp

@@ -534 +534 @@
      * info too in these leaves (like words about having a constant TSC).
      */
-#if 0
-    /** @todo NT4 installation regression - investigate */
-    /** Note from Intel manuals:
-     * CPUID leaves > 3 < 80000000 are visible only when
-     * IA32_MISC_ENABLES.BOOT_NT4[bit 22] = 0 (default).
-     *
-     */
-    if (pCPUM->aGuestCpuIdStd[0].eax > 5)
-        pCPUM->aGuestCpuIdStd[0].eax = 5;
-#else
-    if (pCPUM->aGuestCpuIdStd[0].eax > 2)
-        pCPUM->aGuestCpuIdStd[0].eax = 2;
-#endif
+    if (pCPUM->aGuestCpuIdStd[0].eax > pVM->cCpuidLeafs)
+        pCPUM->aGuestCpuIdStd[0].eax = pVM->cCpuidLeafs;
+
     for (i = pCPUM->aGuestCpuIdStd[0].eax + 1; i < RT_ELEMENTS(pCPUM->aGuestCpuIdStd); i++)
         pCPUM->aGuestCpuIdStd[i] = pCPUM->GuestCpuIdDef;

trunk/src/VBox/VMM/VM.cpp

@@ -594 +594 @@
                     rc = VERR_INVALID_PARAMETER;
                 }
+            }
+            /*
+             * Set correct CPUID leafs limit, some guests types,
+             * notably Win NT 4.0 may wish to override this value.
+             */
+            if (RT_SUCCESS(rc))
+            {
+                 uint32_t cCpuidLeafs;
+                 rc = CFGMR3QueryU32Def(CFGMR3GetRoot(pVM), "CpuidLeafs", &cCpuidLeafs, 5);
+                 pVM->cCpuidLeafs = cCpuidLeafs;
             }
             if (RT_SUCCESS(rc))
@@ -3572 +3582 @@
     return pUVCpu->vm.s.ThreadEMT;
 }
-

trunk/src/VBox/VMM/VMMAll/CPUMAllRegs.cpp

@@ -1065 +1065 @@
         pCpuId = &pVM->cpum.s.GuestCpuIdDef;
 
+    bool fHasMoreCaches = (*pEcx == 0);
+
     *pEax = pCpuId->eax;
     *pEbx = pCpuId->ebx;
@@ -1076 +1078 @@
         Assert(pVCpu->idCpu <= 255);
         *pEbx |= (pVCpu->idCpu << 24);
+   }
+
+    if ( iLeaf == 4 && fHasMoreCaches &&
+         pVM->cpum.s.enmCPUVendor == CPUMCPUVENDOR_INTEL)
+    {
+        /* Report unified L0 cache, Linux'es num_cpu_cores() requires
+         * that to be non-0 to detect core count correctly. */
+        *pEax |= (1 << 5) | 3;
     }
 
@@ -2048 +2058 @@
     return enmMode;
 }
-

trunk/src/VBox/VMM/VMMAll/EMAll.cpp

@@ -1985 +1985 @@
     pRegFrame->rax = 0;
     pRegFrame->rbx = 0;
-    pRegFrame->rcx = 0;
+    pRegFrame->rcx &= UINT64_C(0x00000000ffffffff);
     pRegFrame->rdx = 0;