Changeset 22218 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Aug 13, 2009 5:25:21 AM (15 years ago)

Author:

vboxsync

Message:

#3547: multicast is broken, fixed multicast array matching.

File:

• trunk/src/VBox/Devices/Network/DevE1000.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Network/DevE1000.cpp

@@ -4059 +4059 @@
 
 /**
- * Returns the value of a bit in a bit vector.
- *
- * @returns true if bit is set.
- * @param   pBitVector      The ethernet packet.
- * @param   u16Bit          Bit number.
- * @thread  EMT
- */
-DECLINLINE(bool) e1kGetBit(uint32_t* pBitVector, uint16_t u16Bit)
-{
-    return !!(pBitVector[u16Bit] & (1 << (u16Bit & 0x1F)));
-}
-
-/**
  * Matches the packet addresses against Multicast Table Array.
  *
@@ -4098 +4085 @@
     if (offset < 3)
         u16Bit = u16Bit >> (4 - offset);
-    return e1kGetBit(pState->auMTA, u16Bit & 0xFFF);
+    return ASMBitTest(pState->auMTA, u16Bit & 0xFFF);
 }
 
@@ -4181 +4168 @@
             pStatus->fVP = true;
             /* It is 802.1q packet indeed, let's filter by VID */
-            if (e1kGetBit(pState->auVFTA, RT_BE2H_U16(u16Ptr[7]) & 0xFFF))
+            if (ASMBitTest(pState->auVFTA, RT_BE2H_U16(u16Ptr[7]) & 0xFFF))
                 return true;
             E1kLog2(("%s Packet filter: no VLAN match\n", INSTANCE(pState)));