Changeset 2223 in vbox for trunk/src

Timestamp:

Apr 19, 2007 1:17:16 PM (18 years ago)

Author:

vboxsync

Message:

Incorrect check for valid hidden selector registers.

Location:

trunk/src/recompiler

Files:

• VBoxRecompiler.c (modified) (4 diffs)
• new/VBoxRecompiler.c (modified) (4 diffs)

trunk/src/recompiler/VBoxRecompiler.c

@@ -1579 +1579 @@
     STAM_PROFILE_START(&pVM->rem.s.StatsState, a);
     register const CPUMCTX *pCtx = pVM->rem.s.pCtx;
-    register unsigned fFlags;
+    register unsigned       fFlags;
+    bool                    fHiddenSelRegsValid = CPUMAreHiddenSelRegsValid(pVM);
 
     /*
@@ -1696 +1697 @@
         if (fFlags & CPUM_CHANGED_LDTR)
         {
-            if (fFlags & CPUM_CHANGED_HIDDEN_SEL_REGS)
+            if (fHiddenSelRegsValid)
             {
                 pVM->rem.s.Env.ldt.selector = pCtx->ldtr;
@@ -1709 +1710 @@
         if (fFlags & CPUM_CHANGED_TR)
         {
-            if (fFlags & CPUM_CHANGED_HIDDEN_SEL_REGS)
+            if (fHiddenSelRegsValid)
             {
                 pVM->rem.s.Env.tr.selector = pCtx->tr;
@@ -1735 +1736 @@
      */
 
-    if (fFlags & CPUM_CHANGED_HIDDEN_SEL_REGS)
+    if (fHiddenSelRegsValid)
     {
         /* The hidden selector registers are valid in the CPU context. */

trunk/src/recompiler/new/VBoxRecompiler.c

@@ -1654 +1654 @@
     STAM_PROFILE_START(&pVM->rem.s.StatsState, a);
     register const CPUMCTX *pCtx = pVM->rem.s.pCtx;
-    register unsigned fFlags;
+    register unsigned       fFlags;
+    bool                    fHiddenSelRegsValid = CPUMAreHiddenSelRegsValid(pVM);
 
     Assert(!pVM->rem.s.fInREM);
@@ -1780 +1781 @@
         if (fFlags & CPUM_CHANGED_LDTR)
         {
-            if (fFlags & CPUM_CHANGED_HIDDEN_SEL_REGS)
+            if (fHiddenSelRegsValid)
             {
                 pVM->rem.s.Env.ldt.selector = pCtx->ldtr;
@@ -1793 +1794 @@
         if (fFlags & CPUM_CHANGED_TR)
         {
-            if (fFlags & CPUM_CHANGED_HIDDEN_SEL_REGS)
+            if (fHiddenSelRegsValid)
             {
                 pVM->rem.s.Env.tr.selector = pCtx->tr;
@@ -1819 +1820 @@
      */
 
-    if (fFlags & CPUM_CHANGED_HIDDEN_SEL_REGS)
+    if (fHiddenSelRegsValid)
     {
         /* The hidden selector registers are valid in the CPU context. */