Changeset 22439 in vbox

Timestamp:

Aug 25, 2009 2:42:08 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

51435

Message:

vbi/mpnotification-r0drv-solaris.c: Removed the racy code.

File:

• trunk/src/VBox/Runtime/r0drv/solaris/vbi/mpnotification-r0drv-solaris.c (modified) (2 diffs)

trunk/src/VBox/Runtime/r0drv/solaris/vbi/mpnotification-r0drv-solaris.c

@@ -44 +44 @@
 *   Global Variables                                                           *
 *******************************************************************************/
+/** CPU watch callback handle. */
 static vbi_cpu_watch_t *g_hVbiCpuWatch = NULL;
+/** Set of online cpus that is maintained by the MP callback.
+ * This avoids locking issues quering the set from the kernel as well as
+ * eliminating any uncertainty regarding the online status during the
+ * callback. */
+RTCPUSET g_rtMpSolarisCpuSet;
 
-RTCPUSET g_rtMpSolarisCpuSet;
 
 static void rtMpNotificationSolarisCallback(void *pvUser, int iCpu, int online)
@@ -74 +79 @@
 
     /*
-     * Cache the list of online CPUs.
+     * Register the callback building the online cpu set as we
+     * do so (current_too = 1).
      */
     RTCpuSetEmpty(&g_rtMpSolarisCpuSet);
-
-    g_hVbiCpuWatch = vbi_watch_cpus(rtMpNotificationSolarisCallback, NULL, 1 /* watch current CPU too */);
-
-    RTCPUID idCpu = RTMpGetMaxCpuId();
-    do
-    {
-        /** @todo vbi_cpu_online() should boundary check "idCpu" rather than hang the system. */
-        if (   RTMpIsCpuPossible(idCpu)
-            && vbi_cpu_online(idCpu))
-        {
-            RTCpuSetAdd(&g_rtMpSolarisCpuSet, idCpu);
-        }
-    } while (idCpu-- > 0);
+    g_hVbiCpuWatch = vbi_watch_cpus(rtMpNotificationSolarisCallback, NULL, 1 /*current_too*/);
 
     return VINF_SUCCESS;