Changeset 2247 in vbox

Timestamp:

Apr 19, 2007 9:40:41 PM (18 years ago)

Author:

vboxsync

Message:

r=bird: ASMMemoryClobber questions.

File:

trunk/include/iprt/asm.h

-              r2245
+              r2247
  * for assembler instructions with side-effects, e.g. port writes to magical guest ports causing
  * guest memory changes by the host
+ *
+ * @todo r=bird: There are two things I don't like there, 1) the name and 2) what about msc?
+ *
+ *      Unless I'm not much mistaken this construct is what is 'barrier' or 'mb' in the linux
+ *      kernel. The ASMMem is used as prefix elsewhere in this file, so ASMMemory* is a confusing
+ *      way to name a new function. I think a more fitting name would be ASMCompilerBarrier,
+ *      ASMCompilerMemoryBarrier, or perhaps ASMMemBarrier.
+ *
+ *      For MSC I guess _ReadWriteBarrier is what we're looking for.
+ *      See http://msdn2.microsoft.com/en-us/library/f20w0x5e(VS.80).aspx
+ *
+ *      We should also add a little note about considering using 'volatile' similar to the one found
+ *      with the _ReadWriteBarrier docs.
  */
 #if RT_INLINE_ASM_GNU_STYLE

Note: See TracChangeset for help on using the changeset viewer.