Changeset 22487 in vbox

Timestamp:

Aug 26, 2009 8:55:09 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

51507

Message:

Main: Fixed a handful status code mixups caught by RTERR_STRICT_RC.

Location:

trunk/src/VBox/Main

Files:

• ApplianceImpl.cpp (modified) (3 diffs)
• ConsoleImpl.cpp (modified) (3 diffs)
• MachineImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/ApplianceImpl.cpp

@@ -989 +989 @@
          * disk images in */
         vrc = RTDirCreateTemp(pszTmpDir);
-        if (RT_FAILURE(rc))
+        if (RT_FAILURE(vrc))
             throw setError(VBOX_E_FILE_ERROR,
                            tr("Cannot create temporary directory '%s'"), pszTmpDir);
@@ -1860 +1860 @@
          * in */
         vrc = RTDirCreateTemp(pszTmpDir);
-        if (RT_FAILURE(rc))
+        if (RT_FAILURE(vrc))
             throw setError(VBOX_E_FILE_ERROR,
                            tr("Cannot create temporary directory '%s'"), pszTmpDir);
@@ -2970 +2970 @@
          * disk images in */
         vrc = RTDirCreateTemp(pszTmpDir);
-        if (RT_FAILURE(rc))
+        if (RT_FAILURE(vrc))
             throw setError(VBOX_E_FILE_ERROR,
                            tr("Cannot create temporary directory '%s'"), pszTmpDir);

trunk/src/VBox/Main/ConsoleImpl.cpp

@@ -7329 +7329 @@
         do
         {
-            LogFlowFunc (("Reattaching new differencing hard disks...\n"));
+            LogFlowFunc(("Reattaching new differencing hard disks...\n"));
 
             com::SafeIfaceArray<IHardDiskAttachment> atts;
-            rc = that->mMachine->
-                COMGETTER(HardDiskAttachments) (ComSafeArrayAsOutParam (atts));
+            rc = that->mMachine->COMGETTER(HardDiskAttachments)(ComSafeArrayAsOutParam(atts));
             if (FAILED (rc))
                 break;
@@ -7350 +7349 @@
                  */
                 rc = atts[i]->COMGETTER(Controller)(&controllerName);
-                if (FAILED (rc))
+                if (FAILED(rc))
                     break;
 
                 rc = that->mMachine->GetStorageControllerByName(controllerName, controller.asOutParam());
-                if (FAILED (rc))
+                if (FAILED(rc))
                     break;
 
@@ -7363 +7362 @@
                  *  to access Console.
                  */
-                int vrc = VMR3ReqCall (that->mpVM, VMCPUID_ANY, &pReq, RT_INDEFINITE_WAIT,
-                                       (PFNRT)reconfigureHardDisks, 5, that->mpVM, lInstance,
-                                       enmController, atts [i], &rc);
-                if (VBOX_SUCCESS (rc))
-                    rc = pReq->iStatus;
-                VMR3ReqFree (pReq);
-                if (FAILED (rc))
-                    break;
-                if (VBOX_FAILURE (vrc))
+                int vrc = VMR3ReqCall(that->mpVM, VMCPUID_ANY, &pReq, RT_INDEFINITE_WAIT,
+                                      (PFNRT)reconfigureHardDisks, 5, that->mpVM, lInstance, enmController, atts[i], &rc);
+                if (RT_SUCCESS(vrc))
+                    vrc = pReq->iStatus;
+                VMR3ReqFree(pReq);
+                if (RT_FAILURE(vrc))
                 {
-                    errMsg = Utf8StrFmt (Console::tr ("%Rrc"), vrc);
+                    errMsg = Utf8StrFmt(Console::tr("%Rrc"), vrc);
                     rc = E_FAIL;
                     break;
                 }
+                if (FAILED(rc))
+                    break;
             }
         }

trunk/src/VBox/Main/MachineImpl.cpp

@@ -5929 +5929 @@
         ULONG portCount;
         rc = pCtl->COMGETTER(PortCount)(&portCount);
-        ComAssertRCRet(rc, rc);
+        ComAssertComRCRet(rc, rc);
         ctl.ulPortCount = portCount;
 
@@ -5940 +5940 @@
                  || (FAILED(rc = pCtl->GetIDEEmulationPort(3, (LONG*)&ctl.lIDE1SlaveEmulationPort)))
                )
-                ComAssertRCRet(rc, rc);
+                ComAssertComRCRet(rc, rc);
         }
 
         /* save the devices now. */
         rc = saveStorageDevices(pCtl, ctl);
-        ComAssertRCRet(rc, rc);
+        ComAssertComRCRet(rc, rc);
 
         data.llStorageControllers.push_back(ctl);