Changeset 22553 in vbox

Timestamp:

Aug 28, 2009 2:10:04 PM (15 years ago)

Author:

vboxsync

Message:

sched-darwin.cpp: Fixed reference of uninitialized variable in rtSchedNativeCalcDefaultPriority.

File:

• trunk/src/VBox/Runtime/r3/darwin/sched-darwin.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/r3/darwin/sched-darwin.cpp

@@ -238 +238 @@
      * If it doesn't match the default, select the closest one from the table.
      */
-    int iCurDiff = RT_ABS(g_pProcessPriority->aTypes[enmType].iBasePriority - iBasePriority);
-    if (iCurDiff)
+    int offBest = RT_ABS(g_pProcessPriority->aTypes[enmType].iBasePriority - iBasePriority);
+    if (offBest)
     {
         const PROCPRIORITY *pProcessPriority = &g_aDefaultPriority;
         for (unsigned i = 0; i < RT_ELEMENTS(g_aPriorities); i++)
         {
-            /* @todo r=poetzsch: gcc warns here. iBasePriority in RT_ABS is the
-             * one which should be initialized not the one from line 234. So I
-             * guess gcc is right. */
-            int iBasePriority = RT_ABS(g_aPriorities[i].aTypes[enmType].iBasePriority - iBasePriority);
-            if (iBasePriority < iCurDiff)
+            int off = RT_ABS(g_aPriorities[i].aTypes[enmType].iBasePriority - iBasePriority);
+            if (off < offBest)
             {
                 g_pProcessPriority = &g_aPriorities[i];
-                if (!iCurDiff)
+                if (!off)
                     break;
-                iCurDiff = iBasePriority;
+                offBest = off;
             }
         }