Changeset 22664 in vbox

Timestamp:

Sep 1, 2009 2:03:09 PM (15 years ago)

Author:

vboxsync

Message:

NAT: hide away dhcp internals, adds helper lookups functions

Location:

trunk/src/VBox/Devices/Network/slirp

Files:

• bootp.c (modified) (2 diffs)
• bootp.h (modified) (2 diffs)
• ip_output.c (modified) (6 diffs)
• slirp.c (modified) (5 diffs)
• slirp.h (modified) (1 diff)
• slirp_state.h (modified) (3 diffs)
• tcp_output.c (modified) (1 diff)
• tcp_subr.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/slirp/bootp.c

@@ -24 +24 @@
 #include <slirp.h>
 
+/** Entry in the table of known DHCP clients. */
+typedef struct
+{
+    uint32_t xid;
+    bool allocated;
+    uint8_t macaddr[6];
+    struct in_addr addr;
+    int number;
+} BOOTPClient;
+/** Number of DHCP clients supported by NAT. */
+#define NB_ADDR     16
+
+#define bootp_clients ((BOOTPClient *)pData->pbootp_clients)
+
 /* XXX: only DHCP is supported */
-
 static const uint8_t rfc1533_cookie[] = { RFC1533_COOKIE };
 static void bootp_reply(PNATState pData, struct mbuf *m0, int off, uint16_t flags);
@@ -683 +696 @@
     }
 }
+
+int bootp_cache_lookup_ip_by_ether(PNATState pData,const uint8_t* ether, uint32_t *pip)
+{
+    int rc = 1;
+    uint32_t ip = INADDR_ANY; 
+    int i;
+    if (ether == NULL || pip == NULL)
+        goto done;
+    for (i = 0; i < NB_ADDR; i++)
+    {
+        if (   bootp_clients[i].allocated
+            && memcmp(bootp_clients[i].macaddr, ether, ETH_ALEN) == 0)
+        {
+            ip = bootp_clients[i].addr.s_addr;
+            rc = 0;
+            break;
+        }
+    }
+done:
+    *pip = ip;
+    return rc;
+}
+
+int bootp_cache_lookup_ether_by_ip(PNATState pData, uint32_t ip, uint8_t *ether)
+{
+    int rc = 1;
+    int i;
+    if (ether == NULL)
+        goto done;
+    for (i = 0; i < NB_ADDR; i++)
+    {
+        if (   bootp_clients[i].allocated
+            && ip == bootp_clients[i].addr.s_addr)
+        {
+            memcpy(ether, bootp_clients[i].macaddr, ETH_ALEN);
+            rc = 0;
+            break;
+        }
+    }
+done:
+    return rc;
+}
+
+/*
+ * Initialize dhcp server 
+ * @returns 0 - if initialization is ok, non-zero otherwise
+ */
+int bootp_dhcp_init(PNATState pData)
+{
+    int rc = 1;
+    pData->pbootp_clients = RTMemAllocZ(sizeof(BOOTPClient) * NB_ADDR);
+    if (pData->pbootp_clients != NULL)
+        rc = 0;
+    return rc;
+}
+
+int bootp_dhcp_fini(PNATState pData)
+{
+    if (pData->pbootp_clients != NULL)
+        RTMemFree(pData->pbootp_clients);
+}

trunk/src/VBox/Devices/Network/slirp/bootp.h

@@ -115 +115 @@
 };
 
-/** Entry in the table of known DHCP clients. */
-typedef struct
-{
-    uint32_t xid;
-    bool allocated;
-    uint8_t macaddr[6];
-    struct in_addr addr;
-    int number;
-} BOOTPClient;
 
 #define DHCP_FLAGS_B (1<<15)
@@ -133 +124 @@
 
 void bootp_input(PNATState, struct mbuf *m);
+int bootp_cache_lookup_ip_by_ether(PNATState, const uint8_t *, uint32_t *);
+int bootp_cache_lookup_ether_by_ip(PNATState, uint32_t, uint8_t *);
+int bootp_dhcp_init(PNATState);
+int bootp_dhcp_fini(PNATState);

trunk/src/VBox/Devices/Network/slirp/ip_output.c

@@ -46 +46 @@
 #include "alias.h"
 
-static const uint8_t* rt_lookup_in_cache(PNATState pData, uint32_t dst)
+static int rt_lookup_in_cache(PNATState pData, uint32_t dst, uint8_t *ether)
 {
-    int i;
-    struct arp_cache_entry *ac = NULL;
-   /* @todo (vasily) to quick ramp up on routing rails
-    * we use information from DHCP server leasings, this
-    * code couldn't detect any changes in network topology
-    * and should be borrowed from other places
-    */
-    LIST_FOREACH(ac, &pData->arp_cache, list)
-    {
-        if (ac->ip == dst)
-            return &ac->ether[0];
-    }
-    for (i = 0; i < NB_ADDR; i++)
-    {
-        if (   bootp_clients[i].allocated
-            && bootp_clients[i].addr.s_addr == dst)
-            return &bootp_clients[i].macaddr[0];
-    }
+    int rc = 1;
+    rc = slirp_arp_lookup_ether_by_ip(pData, dst, ether);
+    if (rc == 0)
+        return rc;
+    rc = bootp_cache_lookup_ether_by_ip(pData, dst, ether);
+    if (rc == 0)
+        return rc;
     /* 
      * no chance to send this packet, sorry, we will request ether address via ARP 
      */
     slirp_arp_who_has(pData, dst); 
-    return NULL; 
+    return rc; 
 }
 
@@ -88 +77 @@
     extern uint8_t zerro_ethaddr[ETH_ALEN];
     struct ethhdr *eh = NULL;
-    const uint8_t *eth_dst = NULL;
+    uint8_t eth_dst[ETH_ALEN];
+    int rc = 1;
 
     STAM_PROFILE_START(&pData->StatIP_output, a);
@@ -134 +124 @@
      eh = (struct ethhdr *)MBUF_HEAD(m);
      if (memcmp(eh->h_source, zerro_ethaddr, ETH_ALEN) == 0)
-         eth_dst = rt_lookup_in_cache(pData, ip->ip_dst.s_addr); 
+     {
+        rc = rt_lookup_in_cache(pData, ip->ip_dst.s_addr, eth_dst);
+        if (rc != 0)
+            goto bad;
+     }
+     else
+    {
+        memcpy(eth_dst, eh->h_source, ETH_ALEN);
+        rc = 0; /*some times we've already know where to send packet*/
+    }
 
     /*
@@ -145 +144 @@
         ip->ip_sum = 0;
         ip->ip_sum = cksum(m, hlen);
-        if (eth_dst != NULL) 
-            memcpy(eh->h_source, eth_dst, ETH_ALEN); 
-        {
-            int rc;
-            STAM_PROFILE_START(&pData->StatALIAS_output, a);
-            rc = LibAliasOut((m->m_la ? m->m_la : pData->proxy_alias), 
-                mtod(m, char *), m->m_len);
-            Log2(("NAT: LibAlias return %d\n", rc));
-            STAM_PROFILE_STOP(&pData->StatALIAS_output, a);
-        }
+    
+        Assert((rc == 0));
+        memcpy(eh->h_source, eth_dst, ETH_ALEN); 
+    
+        STAM_PROFILE_START(&pData->StatALIAS_output, a);
+        rc = LibAliasOut((m->m_la ? m->m_la : pData->proxy_alias), 
+            mtod(m, char *), m->m_len);
+        Log2(("NAT: LibAlias return %d\n", rc));
+        STAM_PROFILE_STOP(&pData->StatALIAS_output, a);
 
         if_output(pData, so, m);
@@ -203 +201 @@
             /* we've calculated eth_dst for first packet */
             eh = (struct ethhdr *)MBUF_HEAD(m);
-            if (eth_dst != NULL) {
-                memcpy(eh->h_source, eth_dst, ETH_ALEN); 
-            }
+            Assert((rc == 0));
+
+            memcpy(eh->h_source, eth_dst, ETH_ALEN); 
 
 #if 0 /* No options */
@@ -247 +245 @@
         ip->ip_sum = 0;
         ip->ip_sum = cksum(m, hlen);
-        {
-            int rc;
-            STAM_PROFILE_START(&pData->StatALIAS_output, a);
-            rc = LibAliasOut((m->m_la ? m->m_la : pData->proxy_alias), 
-                mtod(m, char *), m->m_len);
-            Log2(("NAT: LibAlias return %d\n", rc));
-            STAM_PROFILE_STOP(&pData->StatALIAS_output, a);
-        }
+
+        STAM_PROFILE_START(&pData->StatALIAS_output, a);
+        rc = LibAliasOut((m->m_la ? m->m_la : pData->proxy_alias), 
+            mtod(m, char *), m->m_len);
+        Log2(("NAT: LibAlias return %d\n", rc));
+        STAM_PROFILE_STOP(&pData->StatALIAS_output, a);
 
 sendorfree:

trunk/src/VBox/Devices/Network/slirp/slirp.c

@@ -190 +190 @@
 
 static void activate_port_forwarding(PNATState, struct ethhdr *);
-static uint32_t find_guest_ip(PNATState, uint8_t *);
+static uint32_t find_guest_ip(PNATState, const uint8_t *);
 
 static const uint8_t special_ethaddr[6] =
@@ -515 +515 @@
     link_up = 1;
 
+    bootp_dhcp_init(pData);
     debug_init();
     if_init(pData);
@@ -649 +650 @@
         RTMemFree(ac);
     }
+    bootp_dhcp_fini(pData);
 #ifdef RT_OS_WINDOWS
     WSACleanup();
@@ -1532 +1534 @@
  * @todo  see rt_lookup_in_cache
  */
-static uint32_t find_guest_ip(PNATState pData, uint8_t *eth_addr)
+static uint32_t find_guest_ip(PNATState pData, const uint8_t *eth_addr)
 {
     int i;
+    uint32_t ip = INADDR_ANY;
+    if (eth_addr == NULL)
+        goto done;
     if (memcmp(eth_addr, zerro_ethaddr, ETH_ALEN) == 0
         || memcmp(eth_addr, broadcast_ethaddr, ETH_ALEN) == 0)
         goto done;
-    for (i = 0; i < NB_ADDR; i++)
-    {
-        if (   bootp_clients[i].allocated
-            && memcmp(bootp_clients[i].macaddr, eth_addr, ETH_ALEN) == 0)
-            return bootp_clients[i].addr.s_addr;
-    }
+    if(slirp_arp_lookup_ip_by_ether(pData, eth_addr, &ip) == 0)
+        goto done;
+    bootp_cache_lookup_ip_by_ether(pData, eth_addr, &ip);
 done:
-    return INADDR_ANY;
+    return ip;
 }
 
@@ -1827 +1829 @@
     _8K_1M_CHECK_ARG("TCP_SNDSPACE", kilobytes);
     tcp_sndspace = kilobytes * _1K;
+}
+
+/*
+ * Looking for Ether by ip in ARP-cache
+ * Note: it´s responsible of caller to allocate buffer for result
+ * @returns 0 - if found, 1 - otherwise
+ */
+int slirp_arp_lookup_ether_by_ip(PNATState pData, uint32_t ip, uint8_t *ether)
+{
+    struct arp_cache_entry *ac = NULL;
+    int rc = 1;
+    if (ether == NULL)
+        return rc;
+
+    if (LIST_EMPTY(&pData->arp_cache))
+        return rc;
+
+    LIST_FOREACH(ac, &pData->arp_cache, list)
+    {
+        if (ac->ip == ip)
+        {
+            memcpy(ether, ac->ether, ETH_ALEN);
+            rc = 0;
+            return rc;
+        }
+    }
+    return rc;
+}
+
+/*
+ * Looking for IP by Ether in ARP-cache
+ * Note: it´s responsible of caller to allocate buffer for result
+ * @returns 0 - if found, 1 - otherwise
+ */
+int slirp_arp_lookup_ip_by_ether(PNATState pData, const uint8_t *ether, uint32_t *ip)
+{
+    struct arp_cache_entry *ac = NULL;
+    int rc = 1;
+    *ip = INADDR_ANY;
+    if (LIST_EMPTY(&pData->arp_cache))
+        return rc;
+    LIST_FOREACH(ac, &pData->arp_cache, list)
+    {
+        if (memcmp(ether, ac->ether, ETH_ALEN))
+        {
+            *ip = ac->ip;
+            rc = 0;
+            return rc;
+        }
+    }
+    return rc;
 }
 

trunk/src/VBox/Devices/Network/slirp/slirp.h

@@ -415 +415 @@
 int nbt_alias_load(PNATState);
 int nbt_alias_unload(PNATState);
-#endif
-
+
+int slirp_arp_lookup_ip_by_ether(PNATState, const uint8_t *, uint32_t *);
+int slirp_arp_lookup_ether_by_ip(PNATState, uint32_t, uint8_t *);
+#endif
+

trunk/src/VBox/Devices/Network/slirp/slirp_state.h

@@ -30 +30 @@
 #include "dnsproxy/dnsproxy.h"
 
-/** Number of DHCP clients supported by NAT. */
-#define NB_ADDR     16
 
 /** Where to start DHCP IP number allocation. */
@@ -100 +98 @@
 {
     /* Stuff from boot.c */
-    BOOTPClient bootp_clients[NB_ADDR];
+    void *pbootp_clients;
     const char *bootp_filename;
     /* Stuff from if.c */
@@ -306 +304 @@
 
 #define bootp_filename pData->bootp_filename
-#define bootp_clients pData->bootp_clients
 
 #define if_mtu pData->if_mtu

trunk/src/VBox/Devices/Network/slirp/tcp_output.c

@@ -589 +589 @@
                          so->so_options & SO_DONTROUTE, 0);
 #endif
-#ifdef VBOX_WITH_NAT_SERVICE
-        {
-            struct ethhdr *eh0, *eh;
-            eh = (struct ethhdr *)m->m_dat;
-
-            if (so->so_m != NULL)
-            {
-                eh0 = (struct ethhdr *)so->so_m->m_dat;
-                memcpy(eh->h_source, eh0->h_source, ETH_ALEN);
-            }
-        }
-#endif
         if(so->so_la != NULL)
             m->m_la = so->so_la;

trunk/src/VBox/Devices/Network/slirp/tcp_subr.c

@@ -124 +124 @@
         if ((m = m_get(pData)) == NULL)
             return;
-#ifdef VBOX_WITH_NAT_SERVICE
-        {
-            struct ethhdr *eh0, *eh;
-            Assert(tp->t_socket->so_m);
-            eh0 = (struct ethhdr *)tp->t_socket->so_m->m_dat;
-            eh = (struct ethhdr *)m->m_dat;
-            memcpy(eh->h_source, eh0->h_source, ETH_ALEN);
-        }
-#endif
 #ifdef TCP_COMPAT_42
         tlen = 1;