Changeset 22701 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Sep 2, 2009 10:10:52 AM (15 years ago)

Author:

vboxsync

Message:

Debug checking only in VBOX_STRICT mode.

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -1370 +1370 @@
 
 # ifdef PGMPOOL_WITH_OPTIMIZED_DIRTY_PT
+
+#  ifdef VBOX_STRICT
 /**
  * Check references to guest physical memory in a PAE / PAE page table.
@@ -1421 +1423 @@
     Assert(!cErrors);
 }
+#  endif /* VBOX_STRICT */
 
 /**
@@ -1512 +1515 @@
 #ifdef VBOX_STRICT
     uint64_t fFlags = 0;
-    rc = PGMShwGetPage(VMMGetCpu(pVM), pPage->pvDirtyFault, &fFlags, NULL);
-    AssertMsg(      (rc == VINF_SUCCESS && !(fFlags & X86_PTE_RW))
-                /* In the SMP case the page table might be removed while we wait for the PGM lock in the trap handler. */
-                ||  rc == VERR_PAGE_TABLE_NOT_PRESENT 
-                ||  rc == VERR_PAGE_NOT_PRESENT, 
-                ("PGMShwGetPage -> GCPtr=%RGv rc=%d flags=%RX64\n", pPage->pvDirtyFault, rc, fFlags));
+    RTHCPHYS HCPhys;
+    rc = PGMShwGetPage(VMMGetCpu(pVM), pPage->pvDirtyFault, &fFlags, &HCPhys);
+    AssertMsg(      (   rc == VINF_SUCCESS 
+                     && (!(fFlags & X86_PTE_RW) || HCPhys != pPage->Core.Key))
+              /* In the SMP case the page table might be removed while we wait for the PGM lock in the trap handler. */
+              ||    rc == VERR_PAGE_TABLE_NOT_PRESENT 
+              ||    rc == VERR_PAGE_NOT_PRESENT, 
+              ("PGMShwGetPage -> GCPtr=%RGv rc=%d flags=%RX64\n", pPage->pvDirtyFault, rc, fFlags));
 #endif
 
@@ -1571 +1576 @@
     int rc = PGM_GCPHYS_2_PTR(pPool->CTX_SUFF(pVM), pPage->GCPhys, &pvGst); AssertReleaseRC(rc);
     memcpy(&pPool->aDirtyPages[idxFree][0], pvGst, PAGE_SIZE);
+#ifdef VBOX_STRICT
     pgmPoolTrackCheckPTPaePae(pPool, pPage, (PX86PTPAE)pvShw, (PCX86PTPAE)pvGst);
+#endif
 
     STAM_COUNTER_INC(&pPool->StatDirtyPage);