Changeset 22727 in vbox for trunk

Timestamp:

Sep 2, 2009 11:08:23 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

51854

Message:

AHCI: Fallback to a safe method for processing the PRDTL if mapping guest RAM fails

File:

• trunk/src/VBox/Devices/Storage/DevAHCI.cpp (modified) (7 diffs)

trunk/src/VBox/Devices/Storage/DevAHCI.cpp

@@ -4068 +4068 @@
 
 /**
+ * Fallback scatter gather list creator.
+ * Used if the normal one fails in PDMDevHlpPhysGCPhys2CCPtr() or
+ * PDMDevHlpPhysGCPhys2CCPtrReadonly()
+ *
+ * returns VBox status code.
+ * @param   pAhciPort              The ahci port.
+ * @param   pAhciPortTaskState     The task state which contains the S/G list entries.
+ * @param   fReadonly              If the mappings should be readonly.
+ * @param   cSGEntriesProcessed    Number of entries the normal creator procecssed
+ *                                 before an error occurred. Used to free
+ *                                 any ressources allocated before.
+ * @thread  EMT
+ */
+static int ahciScatterGatherListCreateSafe(PAHCIPort pAhciPort, PAHCIPORTTASKSTATE pAhciPortTaskState,
+                                           bool fReadonly, unsigned cSGEntriesProcessed)
+{
+    CmdHdr                    *pCmdHdr = &pAhciPortTaskState->cmdHdr;
+    PPDMDEVINS                 pDevIns = pAhciPort->CTX_SUFF(pDevIns);
+    PAHCIPORTTASKSTATESGENTRY  pSGInfoCurr  = pAhciPortTaskState->paSGEntries;
+
+    AssertPtr(pAhciPortTaskState->pSGListHead);
+    AssertPtr(pAhciPortTaskState->paSGEntries);
+
+    for (unsigned cSGEntryCurr = 0; cSGEntryCurr < cSGEntriesProcessed; cSGEntryCurr++)
+    {
+        if (pSGInfoCurr->fGuestMemory)
+        {
+            /* Release the lock. */
+            PDMDevHlpPhysReleasePageMappingLock(pDevIns, &pSGInfoCurr->u.direct.PageLock);
+        }
+
+        /* Go to the next entry. */
+        pSGInfoCurr++;
+    }
+
+    if (pAhciPortTaskState->pvBufferUnaligned)
+        RTMemFree(pAhciPortTaskState->pvBufferUnaligned);
+
+    pAhciPortTaskState->cSGListTooBig     = 0;
+
+    RTMemFree(pAhciPortTaskState->pSGListHead);
+    RTMemFree(pAhciPortTaskState->paSGEntries);
+    pAhciPortTaskState->cSGEntries = 1;
+    pAhciPortTaskState->cSGListSize = 1;
+    pAhciPortTaskState->cbBufferUnaligned = pAhciPortTaskState->cbTransfer;
+
+    /* Allocate new buffers and SG lists. */
+    pAhciPortTaskState->pvBufferUnaligned = RTMemAlloc(pAhciPortTaskState->cbTransfer);
+    if (!pAhciPortTaskState->pvBufferUnaligned)
+        return VERR_NO_MEMORY;
+
+    pAhciPortTaskState->pSGListHead = (PPDMDATASEG)RTMemAllocZ(1 * sizeof(PDMDATASEG));
+    if (!pAhciPortTaskState->pSGListHead)
+    {
+        RTMemFree(pAhciPortTaskState->pvBufferUnaligned);
+        return VERR_NO_MEMORY;
+    }
+
+    pAhciPortTaskState->paSGEntries = (PAHCIPORTTASKSTATESGENTRY)RTMemAllocZ(1 * sizeof(AHCIPORTTASKSTATESGENTRY));
+    if (!pAhciPortTaskState->paSGEntries)
+    {
+        RTMemFree(pAhciPortTaskState->pvBufferUnaligned);
+        RTMemFree(pAhciPortTaskState->pSGListHead);
+        return VERR_NO_MEMORY;
+    }
+
+    /* Set pointers. */
+    pAhciPortTaskState->pSGListHead[0].cbSeg = pAhciPortTaskState->cbTransfer;
+    pAhciPortTaskState->pSGListHead[0].pvSeg = pAhciPortTaskState->pvBufferUnaligned;
+
+    pAhciPortTaskState->paSGEntries[0].fGuestMemory = false;
+    pAhciPortTaskState->paSGEntries[0].u.temp.cUnaligned   = AHCI_CMDHDR_PRDTL_ENTRIES(pCmdHdr->u32DescInf);
+    pAhciPortTaskState->paSGEntries[0].u.temp.GCPhysAddrBaseFirstUnaligned = AHCI_RTGCPHYS_FROM_U32(pCmdHdr->u32CmdTblAddrUp, pCmdHdr->u32CmdTblAddr) + AHCI_CMDHDR_PRDT_OFFSET;
+
+    if (pAhciPortTaskState->uTxDir == PDMBLOCKTXDIR_TO_DEVICE)
+        ahciCopyFromSGListIntoBuffer(pDevIns, &pAhciPortTaskState->paSGEntries[0]);
+
+    return VINF_SUCCESS;
+}
+
+/**
  * Create scatter gather list descriptors.
  *
@@ -4082 +4163 @@
     PPDMDEVINS pDevIns = pAhciPort->CTX_SUFF(pDevIns);
     unsigned   cActualSGEntry;
-    unsigned   cSGEntriesR3   = 0;             /* Needed scatter gather list entries in R3. */
+    unsigned   cSGEntriesR3 = 0;               /* Needed scatter gather list entries in R3. */
+    unsigned   cSGEntriesProcessed = 0;        /* Number of SG entries procesed. */
     SGLEntry   aSGLEntry[32];                  /* Holds read sg entries from guest. Biggest seen number of entries a guest set up. */
     unsigned   cSGLEntriesGCRead;
@@ -4219 +4301 @@
                                 pSGInfoCurr++;
                                 pSGEntryCurr++;
+                                cSGEntriesProcessed++;
                             }
                         }
@@ -4303 +4386 @@
 
                                         if (RT_FAILURE(rc))
-                                            AssertMsgFailed(("Creating mapping failed rc=%Rrc\n", rc));
+                                        {
+                                            /* Mapping failed. Fall back to a bounce buffer. */
+                                            ahciLog(("%s: Mapping guest physical address %RGp failed with rc=%Rc\n",
+                                                     __FUNCTION__, GCPhysBufferPageAligned, rc));
+
+                                            return ahciScatterGatherListCreateSafe(pAhciPort, pAhciPortTaskState, fReadonly,
+                                                                                   cSGEntriesProcessed);
+                                        }
 
                                         if ((pbMapping + (GCPhysAddrDataBase - GCPhysBufferPageAligned) == ((uint8_t *)pSGEntryPrev->pvSeg + pSGEntryCurr->cbSeg)))
@@ -4329 +4419 @@
                                         pSGInfoPrev  = pSGInfoCurr;
                                         pSGInfoCurr++;
+                                        cSGEntriesProcessed++;
                                     }
                                     else
@@ -4371 +4462 @@
 
                                     if (RT_FAILURE(rc))
-                                        AssertMsgFailed(("Creating mapping failed rc=%Rrc\n", rc));
+                                    {
+                                        /* Mapping failed. Fall back to a bounce buffer. */
+                                        ahciLog(("%s: Mapping guest physical address %RGp failed with rc=%Rc\n",
+                                                    __FUNCTION__, GCPhysAddrDataBase, rc));
+
+                                        return ahciScatterGatherListCreateSafe(pAhciPort, pAhciPortTaskState, fReadonly,
+                                                                               cSGEntriesProcessed);
+                                    }
 
                                     /* Check for adjacent mappings. */
@@ -4396 +4494 @@
                                     pSGInfoPrev = pSGInfoCurr;
                                     pSGInfoCurr++;
+                                    cSGEntriesProcessed++;
                                 }
                                 else