Changeset 22797 in vbox

Timestamp:

Sep 6, 2009 5:32:44 PM (15 years ago)

Author:

vboxsync

Message:

video 2d accel: next step in using ogl only when needed: working, but disabled to make some test/debug

Location:

trunk/src/VBox/Frontends/VirtualBox

Files:

• include/VBoxFrameBuffer.h (modified) (5 diffs)
• src/VBoxFBQGL.cpp (modified) (15 diffs)

trunk/src/VBox/Frontends/VirtualBox/include/VBoxFrameBuffer.h

@@ -1282 +1282 @@
     static void doSetupMatrix(const QSize & aSize, bool bInverted);
 
-    void vboxDoUpdateViewport(const QRect * pRect);
+    void vboxDoUpdateViewport(const QRect & aRect);
+    void vboxDoUpdateRect(const QRect * pRect);
+
     const QRect & vboxViewport() const {return mViewport;}
 
@@ -1310 +1312 @@
 
 
-    void vboxDoUpdateRect(const QRect * pRect);
 #ifdef VBOXQGL_DBG_SURF
     void vboxDoTestSurfaces(void *context);
@@ -1449 +1450 @@
     void vboxUpdateRect(const QRect * pRect);
 private:
+    void makeCurrent()
+    {
+        if(!mGlCurrent)
+        {
+            mGlCurrent = true;
+            mpOverlayWidget->makeCurrent();
+        }
+    }
+
+    void performDisplayOverlay()
+    {
+        if(mOverlayVisible)
+        {
+#if 0
+            mpOverlayWidget->updateGL();
+#else
+            makeCurrent();
+            mpOverlayWidget->performDisplay();
+            mpOverlayWidget->swapBuffers();
+#endif
+        }
+    }
+
+    void vboxOpExit()
+    {
+        performDisplayOverlay();
+        mGlCurrent = false;
+    }
+
+
     void vboxSetGlOn(bool on);
     bool vboxGetGlOn() { return mGlOn; }
@@ -1454 +1485 @@
     void vboxDoVHWACmdExec(void *cmd);
     void vboxShowOverlay(bool show);
+    bool vboxDoCheckUpdateViewport();
+    void vboxDoVHWACmd(void *cmd);
+    void vboxDoUpdateRect(const QRect * pRect);
     void vboxUpdateOverlayPosition(const QPoint & pos);
     void vboxUpdateOverlay(const QRect & rect, bool show);
@@ -1460 +1494 @@
     bool mGlOn;
     bool mOverlayVisible;
+    bool mGlCurrent;
+    bool mProcessingCommands;
+    QRect mOverlayViewportCoords;
     VBoxVHWADirtyRect mMainDirtyRect;
 

trunk/src/VBox/Frontends/VirtualBox/src/VBoxFBQGL.cpp

@@ -3003 +3003 @@
     if(vp != pw->vboxViewport())
     {
-        pw->vboxDoUpdateViewport(&vp);
+        pw->vboxDoUpdateViewport(vp);
     }
 
@@ -3560 +3560 @@
     }
 
+    Assert(handle != VBOXVHWA_SURFHANDLE_INVALID);
+    Assert(surf->handle() == VBOXVHWA_SURFHANDLE_INVALID);
     surf->setHandle(handle);
+    Assert(surf->handle() == handle);
 
     VBOXQGLLOG_EXIT(("pSurf (0x%x)\n",surf));
@@ -4628 +4631 @@
 #endif
 
-void VBoxGLWidget::vboxDoUpdateViewport(const QRect * pRect)
-{
-    adjustViewport(mDisplay.getPrimary()->size(), *pRect);
-    mViewport = *pRect;
+void VBoxGLWidget::vboxDoUpdateViewport(const QRect & aRect)
+{
+    adjustViewport(mDisplay.getPrimary()->size(), aRect);
+    mViewport = aRect;
 
     const SurfList & primaryList = mDisplay.primaries().surfaces();
@@ -4639 +4642 @@
     {
         VBoxVHWASurfaceBase *pSurf = *pr;
-        pSurf->updateVisibleTargRect(NULL, *pRect);
+        pSurf->updateVisibleTargRect(NULL, aRect);
     }
 
@@ -4653 +4656 @@
         {
             VBoxVHWASurfaceBase *pSurf = *sit;
-            pSurf->updateVisibleTargRect(mDisplay.getPrimary(), *pRect);
+            pSurf->updateVisibleTargRect(mDisplay.getPrimary(), aRect);
         }
     }
@@ -5229 +5232 @@
       mGlOn(false),
       mOverlayVisible(false),
+      mGlCurrent(false),
+      mProcessingCommands(false),
       mCmdPipe(aView)
 {
@@ -5252 +5257 @@
 {
     Q_UNUSED(pEvent);
+    Assert(!mProcessingCommands);
+    mProcessingCommands = true;
+    Assert(!mGlCurrent);
+    mGlCurrent = false; /* just a fall-back */
     VBoxVHWACommandElement * pFirst = mCmdPipe.detachCmdList(NULL, NULL);
     do
@@ -5259 +5268 @@
         pFirst = mCmdPipe.detachCmdList(pFirst, pLast);
     } while(pFirst);
+
+    mProcessingCommands = false;
+    vboxOpExit();
 }
 
@@ -5264 +5276 @@
                          ULONG aW, ULONG aH)
 {
+#if 1
     QRect r(aX, aY, aW, aH);
     mCmdPipe.postCmd(VBOXVHWA_PIPECMD_PAINT, &r);
     return S_OK;
+#else
+    /* We're not on the GUI thread and update() isn't thread safe in
+     * Qt 4.3.x on the Win, Qt 3.3.x on the Mac (4.2.x is),
+     * on Linux (didn't check Qt 4.x there) and probably on other
+     * non-DOS platforms, so post the event instead. */
+    QApplication::postEvent (mView,
+                             new VBoxRepaintEvent (aX, aY, aW, aH));
+
+    return S_OK;
+#endif
+}
+
+bool VBoxQGLOverlayFrameBuffer::vboxDoCheckUpdateViewport()
+{
+    Assert(0);
+//    QRect vp(mView->contentsX(), mView->contentsY(), mpOverlayWidget->width(), mpOverlayWidget->height());
+//    if(vp != mpOverlayWidget->vboxViewport())
+//    {
+//        mpOverlayWidget->vboxDoUpdateViewport(vp);
+//        return true;
+//    }
+    return false;
 }
 
 void VBoxQGLOverlayFrameBuffer::paintEvent (QPaintEvent *pe)
 {
+    if(mOverlayVisible && !mProcessingCommands)
+    {
+        Assert(!mGlCurrent);
+        vboxOpExit();
+    }
+
     VBoxQImageFrameBuffer::paintEvent (pe);
 }
@@ -5280 +5321 @@
     if(mGlOn)
     {
+        Assert(!mGlCurrent);
+        mGlCurrent = false;
+        makeCurrent();
         /* need to ensure we're in synch */
         vboxSynchGl();
-    }
+        vboxOpExit();
+        Assert(mGlCurrent == false);
+    }
+}
+
+void VBoxQGLOverlayFrameBuffer::vboxDoVHWACmd(void *cmd)
+{
+    vboxDoVHWACmdExec(cmd);
+
+    CDisplay display = mView->console().GetDisplay();
+    Assert (!display.isNull());
+
+    display.CompleteVHWACommand((BYTE*)cmd);
+}
+
+void VBoxQGLOverlayFrameBuffer::vboxDoUpdateRect(const QRect * pRect)
+{
+    if(mGlOn)
+    {
+        makeCurrent();
+        mpOverlayWidget->vboxDoUpdateRect(pRect);
+//        if(mOverlayVisible)
+//        {
+//            mpOverlayWidget->performDisplay();
+//            mpOverlayWidget->swapBuffers();
+//        }
+        vboxOpExit();
+    }
+
+    mView->viewport()->repaint (pRect->x() - mView->contentsX(),
+            pRect->y() - mView->contentsY(),
+            pRect->width(), pRect->height());
+
+    /* translate to widget coords
+     * @todo: may eliminate this */
+//    QPaintEvent pe(pRect->translated(-mView->contentsX(), -mView->contentsY()));
+//    VBoxQImageFrameBuffer::paintEvent (&pe);
 }
 
@@ -5324 +5404 @@
 {
     mpOverlayWidget->setVisible(show);
+    mOverlayVisible = show;
 }
 
 void VBoxQGLOverlayFrameBuffer::vboxUpdateOverlayPosition(const QPoint & pos)
 {
+    makeCurrent();
+
     mpOverlayWidget->move(pos);
+
+    /* */
+    QRect rect = mpOverlayWidget->vboxViewport();
+    rect.moveTo(pos);
+    mpOverlayWidget->vboxDoUpdateViewport(rect);
 }
 
@@ -5335 +5423 @@
     mpOverlayWidget->move(rect.x(), rect.y());
     mpOverlayWidget->resize(rect.width(), rect.height());
-    mpOverlayWidget->setVisible(show);
+
+    mpOverlayWidget->vboxDoUpdateViewport(rect);
+
+    vboxShowOverlay(show);
 }
 
@@ -5341 +5432 @@
 {
     struct _VBOXVHWACMD * pCmd = (struct _VBOXVHWACMD *)cmd;
+    makeCurrent();
     switch(pCmd->enmCmd)
     {
@@ -5401 +5493 @@
                 vboxUpdateOverlay(overRect, true);
             }
+            else
+            {
+                vboxShowOverlay(false);
+            }
         } break;
         case VBOXVHWACMD_TYPE_SURF_OVERLAY_SETPOSITION:
@@ -5452 +5548 @@
         {
         case VBOXVHWA_PIPECMD_PAINT:
-//            vboxDoUpdateRect(&pCmd->rect());
+            vboxDoUpdateRect(&pCmd->rect());
             break;
 #ifdef VBOX_WITH_VIDEOHWACCEL
         case VBOXVHWA_PIPECMD_VHWA:
-//            vboxDoVHWACmd(pCmd->vhwaCmd());
+            vboxDoVHWACmd(pCmd->vhwaCmd());
             break;
         case VBOXVHWA_PIPECMD_OP: