Changeset 22814 in vbox for trunk

Timestamp:

Sep 7, 2009 4:34:29 PM (15 years ago)

Author:

vboxsync

Message:

HGCM: delete a disconnected client handle. Fixes HGCMReset hang/assertion.

File:

• trunk/src/VBox/Main/hgcm/HGCM.cpp (modified) (3 diffs)

trunk/src/VBox/Main/hgcm/HGCM.cpp

@@ -1038 +1038 @@
 {
     ASMAtomicIncU32 (&m_u32RefCnt);
-    LogFlowFunc(("m_u32RefCnt = %d\n", m_u32RefCnt));
+    LogFlowFunc(("[%s] m_u32RefCnt = %d\n", m_pszSvcName, m_u32RefCnt));
 }
 
@@ -1361 +1361 @@
         else
         {
-            LogRel(("[%s] hgcmMsgAlloc(%p, SVC_MSG_DISCONNECT) failed %Rrc\n",
-                    RT_VALID_PTR(m_pszSvcName)? m_pszSvcName: "", m_thread, rc));
+            LogRel(("(%d, %d) [%s] hgcmMsgAlloc(%p, SVC_MSG_DISCONNECT) failed %Rrc\n",
+                    u32ClientId, fFromService, RT_VALID_PTR(m_pszSvcName)? m_pszSvcName: "", m_thread, rc));
         }
     }
@@ -1377 +1377 @@
             if (m_cClients > i)
             {
-                memmove (&m_paClientIds[i], &m_paClientIds[i + 1], m_cClients - i);
+                memmove (&m_paClientIds[i], &m_paClientIds[i + 1], sizeof (m_paClientIds[0]) * (m_cClients - i));
             }
 
+            /* Delete the client handle. */
+            hgcmObjDeleteHandle (u32ClientId);
+
+            /* The service must be released. */
+            ReleaseService ();
+
             break;
         }
     }
-
-    /* Delete the client handle. */
-    hgcmObjDeleteHandle (u32ClientId);
-
-    /* The service must be released. */
-    ReleaseService ();
 
     LogFlowFunc(("rc = %Rrc\n", rc));