Changeset 22852 in vbox

Timestamp:

Sep 9, 2009 12:09:13 AM (15 years ago)

Author:

vboxsync

Message:

video hw accel: additional overlay update fixes

Location:

trunk/src/VBox/Frontends/VirtualBox

Files:

• include/VBoxFBOverlay.h (modified) (4 diffs)
• src/VBoxFBOverlay.cpp (modified) (8 diffs)
• src/VBoxFBQGL.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/include/VBoxFBOverlay.h

@@ -573 +573 @@
 
     const VBoxVHWADirtyRect & getDirtyRect() { return mUpdateMem2TexRect; }
-
 private:
     void doSetRectValuesInternal(const QRect & aTargRect, const QRect & aSrcRect, const QRect & aVisTargRect);
@@ -1062 +1061 @@
     const QRect & vboxViewport() const {return mViewport;}
 
-    bool performDisplay(bool bForce) { return mDisplay.performDisplay(bForce); }
+    bool performDisplayAndSwap(bool bForce)
+    {
+        bForce = mDisplay.performDisplay(bForce | mRepaintNeeded);
+        if(bForce)
+        {
+            swapBuffers();
+        }
+        return bForce;
+    }
 protected:
 
@@ -1150 +1157 @@
     ulong  mPixelFormat;
     bool   mUsesGuestVRAM;
+
+    bool mRepaintNeeded;
+
 //    bool   mbVGASurfCreated;
     QRect mViewport;
@@ -1259 +1269 @@
 #else
             makeCurrent();
-            mpOverlayWidget->performDisplay(false);
-            mpOverlayWidget->swapBuffers();
+            mpOverlayWidget->performDisplayAndSwap(false);
 #endif
         }

trunk/src/VBox/Frontends/VirtualBox/src/VBoxFBOverlay.cpp

@@ -2941 +2941 @@
     mPixelFormat(0),
     mUsesGuestVRAM(false),
+    mRepaintNeeded(false),
 //    mbVGASurfCreated(false),
     mView(aView),
@@ -3524 +3525 @@
         }
     }
+
+    /* just in case we destroy a visible overlay sorface */
+    mRepaintNeeded = true;
 
     void * test = mSurfHandleTable.remove(pCmd->u.in.hSurf);
@@ -3619 +3623 @@
     pTargSurf->getComplexList()->setCurrentVisible(pTargSurf);
 
+    mRepaintNeeded = true;
 #ifdef DEBUG
     pCurrSurf->cFlipsCurr++;
@@ -3794 +3799 @@
     }
 
+    mRepaintNeeded = true;
+
     return VINF_SUCCESS;
 }
@@ -3812 +3819 @@
     QPoint pos(pCmd->u.in.xPos, pCmd->u.in.yPos);
 
+#ifdef DEBUG_misha
+    Assert(pDstSurf == mDisplay.getVGA());
+    Assert(mDisplay.getVGA() == mDisplay.getPrimary());
+#endif
+    if(pSrcSurf->getComplexList()->current() != NULL)
+    {
+        Assert(pDstSurf);
+        if(pDstSurf != mDisplay.getPrimary())
+        {
+            mDisplay.updateVGA(pDstSurf);
+            pDstSurf->getComplexList()->setCurrentVisible(pDstSurf);
+        }
+    }
+
+    mRepaintNeeded = true;
+
     for (SurfList::const_iterator it = surfaces.begin();
              it != surfaces.end(); ++ it)
@@ -3829 +3852 @@
 
     vboxCheckUpdateAddress (pSurf, pCmd->u.in.offSurface);
+
+    mRepaintNeeded = true;
 
 //    VBOXVHWA_CKEY_COLORSPACE
@@ -5474 +5499 @@
             VBOXVHWACMD_SURF_UNLOCK * pBody = VBOXVHWACMD_BODY(pCmd, VBOXVHWACMD_SURF_UNLOCK);
             pCmd->rc = vhwaSurfaceUnlock(pBody);
+            /* mNeedOverlayRepaint is set inside the vhwaSurfaceUnlock */
         } break;
         case VBOXVHWACMD_TYPE_SURF_BLT:
@@ -5515 +5541 @@
             VBOXVHWACMD_SURF_COLORKEY_SET * pBody = VBOXVHWACMD_BODY(pCmd, VBOXVHWACMD_SURF_COLORKEY_SET);
             pCmd->rc = mpOverlayWidget->vhwaSurfaceColorkeySet(pBody);
+            mNeedOverlayRepaint = true;
         } break;
         case VBOXVHWACMD_TYPE_QUERY_INFO1:

trunk/src/VBox/Frontends/VirtualBox/src/VBoxFBQGL.cpp

@@ -130 +130 @@
     }
 
-    pw->performDisplay(true);
-
-    pw->swapBuffers();
+    pw->performDisplayAndSwap(true);
 }