Changeset 22868 in vbox

Timestamp:

Sep 9, 2009 3:36:19 PM (15 years ago)

Author:

vboxsync

Message:

Windows guest display driver: fixed incorrect creation of the screen bitmap and surface in DrvEnableSurface.

File:

• trunk/src/VBox/Additions/WINNT/Graphics/Display/enable.c (modified) (1 diff)

trunk/src/VBox/Additions/WINNT/Graphics/Display/enable.c

@@ -759 +759 @@
     ppdev->ulBitmapType = ulBitmapType;
 #else
-    hsurf = (HSURF) EngCreateBitmap(sizl,
-                                    ppdev->lDeltaScreen,
-                                    ulBitmapType,
-                                    (ppdev->lDeltaScreen > 0) ? BMF_TOPDOWN : 0,
-                                    (PVOID) (ppdev->pjScreen));
-
-    if (hsurf == (HSURF) 0)
-    {
-        DISPDBG((0, "DISP DrvEnableSurface failed EngCreateBitmap\n"));
+    /* Create a GDI bitmap which will be used to draw with Eng* functions. */
+    ppdev->hsurfScreenBitmap = (HSURF)EngCreateBitmap(sizl,
+                                                      ppdev->lDeltaScreen,
+                                                      ulBitmapType,
+                                                      (ppdev->lDeltaScreen > 0) ? BMF_TOPDOWN : 0,
+                                                      (PVOID) (ppdev->pjScreen));
+
+    if (ppdev->hsurfScreenBitmap == (HSURF) 0)
+    {
+        DISPDBG((0, "DISP DrvEnableSurface failed EngCreateBitmap ppdev->hsurfScreenBitmap\n"));
         goto l_Failure;
     }
     else
     {
-        ppdev->hsurfScreenBitmap = hsurf;
-
-        if (!EngAssociateSurface(hsurf, ppdev->hdevEng, 0))
-        {
-            DISPDBG((0, "DISP DrvEnableSurface failed EngAssociateSurface for ScreenBitmap.\n"));
+        /* Get the GDI bitmap SURFOBJ, which will be passed to Eng*. */
+        ppdev->psoScreenBitmap = EngLockSurface(ppdev->hsurfScreenBitmap);
+
+        /* Create device managed surface, which will represent screen for GDI. */
+        ppdev->hsurfScreen = (HSURF)EngCreateDeviceSurface((DHSURF)ppdev, /* Handle assigned by the device. */
+                                                           sizl,
+                                                           ulBitmapType);
+
+        if (ppdev->hsurfScreen == (HSURF) 0)
+        {
+            DISPDBG((0, "DISP DrvEnableSurface failed EngCreateDeviceSurface ppdev->hsurfScreen\n"));
             goto l_Failure;
         }
         else
         {
-            SURFOBJ *pso = EngLockSurface(hsurf);
-
-            ppdev->psoScreenBitmap = pso;
-
-            hsurf = (HSURF) EngCreateDeviceSurface((DHSURF)pso,
-                                                    sizl,
-                                                    ulBitmapType);
-
-            if (hsurf == (HSURF) 0)
-            {
-                DISPDBG((0, "DISP DrvEnableSurface failed EngCreateDeviceSurface\n"));
+            /* Tell GDI that the driver will handle drawing operations on the screen surface. */
+            if (!EngAssociateSurface(ppdev->hsurfScreen, ppdev->hdevEng, flHooks))
+            {
+                DISPDBG((0, "DISP DrvEnableSurface failed EngAssociateSurface for Screen.\n"));
                 goto l_Failure;
             }
             else
             {
-                ppdev->hsurfScreen = hsurf;
-                /* Must set dhsurf to make sure GDI doesn't ignore our hooks */
-                ppdev->psoScreenBitmap->dhsurf = (DHSURF)hsurf;
-
-                if (!EngAssociateSurface(hsurf, ppdev->hdevEng, flHooks))
-                {
-                    DISPDBG((0, "DISP DrvEnableSurface failed EngAssociateSurface for Screen.\n"));
-                    goto l_Failure;
-                }
-                else
-                {
-                    ppdev->flHooks = flHooks;
-                    ppdev->ulBitmapType = ulBitmapType;
-                }
+                ppdev->flHooks = flHooks;
+                ppdev->ulBitmapType = ulBitmapType;
+
+                DISPDBG((0, "DISP DrvEnableSurface success ppdev %p, ppdev->hsurfScreen %p\n", ppdev, ppdev->hsurfScreen));
             }
         }