Changeset 22907 in vbox for trunk/src/VBox/Devices

Timestamp:

Sep 10, 2009 11:27:09 AM (15 years ago)

Author:

vboxsync

Message:

DevPcBios.cpp: Don't use RTStrAPrintf for simple stuff like this, it may fail.

File:

• trunk/src/VBox/Devices/PC/DevPcBios.cpp (modified) (1 diff)

trunk/src/VBox/Devices/PC/DevPcBios.cpp

@@ -1149 +1149 @@
     pOEMStrings->u8Count          = 2;
 
-    char* pszVBoxVer, *pszVBoxRev;
-    RTStrAPrintf(&pszVBoxVer, "vboxVer_%d.%d.%d",
-                  RTBldCfgVersionMajor(), RTBldCfgVersionMinor(), RTBldCfgVersionBuild());
-    RTStrAPrintf(&pszVBoxRev, "vboxRev_%ld", RTBldCfgRevision());
-    READCFGSTR("DmiOEMVBoxVer", pszDmiOEMVBoxVer, pszVBoxVer);
-    READCFGSTR("DmiOEMVBoxRev", pszDmiOEMVBoxRev, pszVBoxRev);
+    char szTmp[64];
+    RTStrPrintf(szTmp, sizeof(szTmp), "vboxVer_%u.%u.%u",
+                RTBldCfgVersionMajor(), RTBldCfgVersionMinor(), RTBldCfgVersionBuild());
+    READCFGSTR("DmiOEMVBoxVer", pszDmiOEMVBoxVer, szTmp);
+    RTStrPrintf(szTmp, sizeof(szTmp), "vboxRev_%u", RTBldCfgRevision());
+    READCFGSTR("DmiOEMVBoxRev", pszDmiOEMVBoxRev, szTmp);
     SETSTRING(pOEMStrings->u8VBoxVersion, pszDmiOEMVBoxVer);
     SETSTRING(pOEMStrings->u8VBoxRevision, pszDmiOEMVBoxRev);
-    RTStrFree(pszVBoxVer);
-    RTStrFree(pszVBoxRev);
     *pszStr++                    = '\0';