Changeset 22971 in vbox for trunk/src/VBox/Devices

Timestamp:

Sep 12, 2009 6:23:57 PM (15 years ago)

Author:

vboxsync

Message:

NAT: make udp fault more clear (excluding warns on success exit of built-in service routines)

File:

• trunk/src/VBox/Devices/Network/slirp/udp.c (modified) (4 diffs)

trunk/src/VBox/Devices/Network/slirp/udp.c

@@ -158 +158 @@
     {
         bootp_input(pData, m);
-        goto bad;
+        goto done;
     }
 
@@ -174 +174 @@
         m->m_len -= sizeof(struct udpiphdr);
         udp_output2(pData, NULL, m, &src, &dst, IPTOS_LOWDELAY);
-        goto bad;
+        goto done;
     }
     /*
@@ -183 +183 @@
     {
         tftp_input(pData, m);
-        goto bad;
+        goto done;
     }
 
@@ -301 +301 @@
     Log2(("NAT: UDP datagram to %R[IP4] with size(%d) claimed as bad\n", 
         &ip->ip_dst, ip->ip_len));
+done: 
+    /* some services like bootp(built-in), dns(buildt-in) and dhcp don't need sockets
+     * and create new m'buffers to send them to guest, so we'll free their incomming 
+     * buffers here. 
+     */
     m_freem(pData, m);
     return;