Changeset 23013 in vbox

Timestamp:

Sep 14, 2009 4:41:46 PM (15 years ago)

Author:

vboxsync

Message:

PDMAsyncCompletion: Make it work on Solaris. directio doesn't work on ZFS unfortunately. Shouldn't really matter because ZFS supports write throttling to prevent the issues we encountered with other hosts

File:

• trunk/src/VBox/VMM/PDMAsyncCompletionFile.cpp (modified) (1 diff)

trunk/src/VBox/VMM/PDMAsyncCompletionFile.cpp

@@ -593 +593 @@
     }
 
-    pEpFile->fFlags = fFileFlags;
-
     /* Open with final flags. */
     rc = RTFileOpen(&pEpFile->File, pszUri, fFileFlags);
+    if (rc == VERR_INVALID_FUNCTION)
+    {
+        /*
+         * Solaris doesn't support directio on ZFS so far. :-\
+         * Trying to enable it returns VERR_INVALID_FUNCTION
+         * (ENOTTY). Remove it and hope for the best.
+         * ZFS supports write throttling in case applications
+         * write more data than can be synced to the disk
+         * without blocking the whole application.
+         */
+        fFileFlags &= ~RTFILE_O_NO_CACHE;
+
+        /* Open again. */
+        rc = RTFileOpen(&pEpFile->File, pszUri, fFileFlags);
+    }
+
     if (RT_SUCCESS(rc))
     {
+        pEpFile->fFlags = fFileFlags;
+
         rc = RTFileGetSize(pEpFile->File, (uint64_t *)&pEpFile->cbFile);
         if (RT_SUCCESS(rc))