Changeset 23090 in vbox

Timestamp:

Sep 17, 2009 12:28:50 PM (15 years ago)

Author:

vboxsync

Message:

Fixed flushing of reused pages

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -1585 +1585 @@
     unsigned cChanges = pgmPoolTrackFlushPTPaePae(pPool, pPage, (PX86PTPAE)pvShw, (PCX86PTPAE)pvGst, (PCX86PTPAE)&pPool->aDirtyPages[idxSlot][0], fAllowRemoval, &fFlush);
     STAM_PROFILE_STOP(&pPool->StatTrackDeref,a);
-
     /** Note: we might want to consider keeping the dirty page active in case there were many changes. */
-    if (fFlush)
-    {
-        Assert(fAllowRemoval);
-        Log(("Flush reused page table!\n"));
-        pgmPoolFlushPage(pPool, pPage);
-        STAM_COUNTER_INC(&pPool->StatForceFlushReused);
-        return;
-    }
 
     /* This page is likely to be modified again, so reduce the nr of modifications just a bit here. */
@@ -1610 +1601 @@
     pPool->aIdxDirtyPages[idxSlot] = NIL_PGMPOOL_IDX;
     Assert(pPool->cDirtyPages <= RT_ELEMENTS(pPool->aIdxDirtyPages));
-    Log(("Removed dirty page %RGp cMods=%d\n", pPage->GCPhys, pPage->cModifications));
+    if (fFlush)
+    {
+        Assert(fAllowRemoval);
+        Log(("Flush reused page table!\n"));
+        pgmPoolFlushPage(pPool, pPage);
+        STAM_COUNTER_INC(&pPool->StatForceFlushReused);
+    }
+    else
+        Log(("Removed dirty page %RGp cMods=%d\n", pPage->GCPhys, pPage->cModifications));
 }