Changeset 23101 in vbox for trunk/src

Timestamp:

Sep 17, 2009 3:00:50 PM (15 years ago)

Author:

vboxsync

Message:

DevPCNet: fixed rare case of RX freezing

File:

• trunk/src/VBox/Devices/Network/DevPCNet.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Network/DevPCNet.cpp

@@ -2609 +2609 @@
 {
     if (CSR_RXON(pThis))
-        if (HOST_IS_OWNER(CSR_CRST(pThis)))     /* Only poll RDTEs if none available */
+    {
+        /*
+         * The second case is important for pcnetWaitReceiveAvail(): If CSR_CRST(pThis) was
+         * true but pcnetCanReceive() returned false for some other reason we need to check
+         * _now_ if we have to wakeup pcnetWaitReceiveAvail().
+         */
+        if (   HOST_IS_OWNER(CSR_CRST(pThis))  /* only poll RDTEs if none available or ... */
+            || pThis->fMaybeOutOfSpace)        /* ... for waking up pcnetWaitReceiveAvail() */
             pcnetRdtePoll(pThis);
+    }
 
     if (CSR_TDMD(pThis) || (CSR_TXON(pThis) && !CSR_DPOLL(pThis)))
@@ -2664 +2672 @@
     /* If the receive thread is waiting for new descriptors, poll TX/RX even if polling
      * disabled. We wouldn't need to poll for new TX descriptors in that case but it will
-     * not hurt as waiting for RX descriptors should occur very seldom */
+     * not hurt as waiting for RX descriptors should happen very seldom */
     if (RT_LIKELY(   !CSR_STOP(pThis)
                   && !CSR_SPND(pThis)