Changeset 23118 in vbox for trunk/src

Timestamp:

Sep 18, 2009 9:54:50 AM (15 years ago)

Author:

vboxsync

Message:

DevVGA_VBVA.cpp: Fixed a too greedy memset in vbvaVHWAHHCommandCreate. (cbCmd=0 -> heap corruption.)

File:

• trunk/src/VBox/Devices/Graphics/DevVGA_VBVA.cpp (modified) (7 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA_VBVA.cpp

@@ -1 @@
-/*
+/** @file
  * VirtualBox Video Acceleration (VBVA).
  */
@@ -330 +330 @@
     } dirtyRect;
     memset(&dirtyRect, 0, sizeof(dirtyRect));
-    
+
     bool fUpdate = false; /* Whether there were any updates. */
 
@@ -456 +456 @@
 
     int rc = pVGAState->pDrv->pfnVBVAResize (pVGAState->pDrv, &pView->view, &pView->screen, pu8VRAM);
-    
+
     /* @todo process VINF_VGA_RESIZE_IN_PROGRESS? */
-    
+
     return rc;
 }
@@ -532 +532 @@
                          + pShape->u32Width * 4 * pShape->u32Height;
     }
-    
+
     if (cbPointerData > cbShape - RT_OFFSETOF(VBVAMOUSEPOINTERSHAPE, au8Data))
     {
@@ -618 +618 @@
               pView->screen.u32Width,
               pView->screen.u32Height,
-              pView->screen.u16BitsPerPixel, 
+              pView->screen.u16BitsPerPixel,
               pView->screen.u16Flags));
 
@@ -852 +852 @@
     if (pHdr)
     {
-        memset(pHdr, 0, sizeof(VBOXVHWACMD));
+        memset(pHdr, 0, VBOXVHWACMD_HEADSIZE());
         pHdr->cRefs = 1;
         pHdr->rc = VERR_GENERAL_FAILURE;
@@ -1165 +1165 @@
             /* Guest submits an array of VBVAINFOVIEW structures. */
             VBVAINFOVIEW *pView = (VBVAINFOVIEW *)pvBuffer;
-            
+
             for (;
                  cbBuffer >= sizeof (VBVAINFOVIEW);