Changeset 2324 in vbox for trunk/src/VBox

Timestamp:

Apr 23, 2007 8:22:00 PM (18 years ago)

Author:

vboxsync

Message:

fixed PGMVerifyAccess(), we sometimes did not check the last page

File:

• trunk/src/VBox/VMM/VMMAll/PGMAll.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/PGMAll.cpp

@@ -505 +505 @@
              || Addr + cbSize < Addr))
     {
-        Addr += PAGE_SIZE;
-        if (cbSize > PAGE_SIZE)
-            cbSize -= PAGE_SIZE;
-        else
-            cbSize = 0;
-
         /* Don't recursively call PGMVerifyAccess as we might run out of stack. */
         for (;;)
         {
+            Addr += PAGE_SIZE;
+            if (cbSize > PAGE_SIZE)
+                cbSize -= PAGE_SIZE;
+            else
+                cbSize = 1;
             rc = PGMVerifyAccess(pVM, Addr, 1, fAccess);
             if (rc != VINF_SUCCESS)
                 break;
-
-            if (cbSize <= PAGE_SIZE)
+            if (PAGE_ADDRESS(Addr) == PAGE_ADDRESS(Addr + cbSize - 1))
                 break;
-            cbSize -= PAGE_SIZE;
-            Addr += PAGE_SIZE;
         }
     }